third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Implement WebBluetooth getDescriptor[s] Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.idl ('k') | third_party/WebKit/Source/modules/modules_idl_files.gni » ('j') | third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

index e25183c0f3154014b93ec5835f1047579c084a34..82c8b229ed9fc8797658ecea25e6f649649cbbad 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

@@ -44,7 +44,7 @@ DEFINE_TRACE(BluetoothRemoteGATTService) {

visitor->trace(m_device);

}

-// Callback that allows us to resolve the promise with a single Characteristic

+// Callback that allows us to resolve the promise with a single characteristic

// or with a vector owning the characteristics.

void BluetoothRemoteGATTService::GetCharacteristicsCallback(

const String& serviceInstanceId,