third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Remove macos restriction Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/bluetooth/web_bluetooth_service_impl.cc ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.idl ('k') | third_party/WebKit/Source/modules/modules_idl_files.gni » ('j') | third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

index 84d915fd495db3acdbbf855b6811c19d87763f45..73f1f397416d91620cd2fcb36a6b1fa71ca04823 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

@@ -55,7 +55,7 @@ class GetCharacteristicsCallback

: m_service(service), m_quantity(quantity), m_resolver(resolver) {

// We always check that the device is connected before constructing this

// object.

- CHECK(m_service->device()->gatt()->connected());

+ DCHECK(m_service->device()->gatt()->connected());

m_service->device()->gatt()->AddToActiveAlgorithms(m_resolver.get());

}