Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)
Patch Set: Remove macos restriction Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
index 7b5c570703b7dd5d1cb027ef1671336dc2d69945..2a4e39f423381613db9f211a4f7d224c6872fe42 100644
--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
@@ -80,6 +80,13 @@ class BluetoothRemoteGATTCharacteristic final
String uuid() { return m_webCharacteristic->uuid; }
BluetoothCharacteristicProperties* properties() { return m_properties; }
DOMDataView* value() const { return m_value; }
+ ScriptPromise getDescriptor(ScriptState*,
+ const StringOrUnsignedLong& descriptor,
+ ExceptionState&);
+ ScriptPromise getDescriptors(ScriptState*, ExceptionState&);
+ ScriptPromise getDescriptors(ScriptState*,
+ const StringOrUnsignedLong& descriptor,
+ ExceptionState&);
ScriptPromise readValue(ScriptState*);
ScriptPromise writeValue(ScriptState*, const DOMArrayPiece&);
ScriptPromise startNotifications(ScriptState*);
@@ -93,12 +100,18 @@ class BluetoothRemoteGATTCharacteristic final
RegisteredEventListener&) override;
private:
- friend class ReadValueCallback;
- friend class WriteValueCallback;
+ friend class CharacteristicReadValueCallback;
+ friend class CharacteristicWriteValueCallback;
friend class NotificationsCallback;
+ friend class GetDescriptorsCallback;
+ friend class BluetoothRemoteGATTDescriptor;
BluetoothRemoteGATTServer* gatt() { return m_service->device()->gatt(); }
+ ScriptPromise getDescriptorsImpl(ScriptState*,
+ mojom::blink::WebBluetoothGATTQueryQuantity,
+ const String& descriptorUUID = String());
+
std::unique_ptr<WebBluetoothRemoteGATTCharacteristicInit> m_webCharacteristic;
Member<BluetoothRemoteGATTService> m_service;
bool m_stopped;

Powered by Google App Engine
This is Rietveld 408576698