third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: rebase to master Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h » ('j') | third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl

index 2fc89d59c260d63f8d04034867cfda32d5f2518d..915939f038d685b06a7c66c5c980cfaad5e603d8 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl

@@ -14,8 +14,8 @@

readonly attribute UUID uuid;

readonly attribute BluetoothCharacteristicProperties properties;

readonly attribute DataView? value;

- // Promise<BluetoothRemoteGATTDescriptor> getDescriptor(BluetoothDescriptorUUID descriptor);

- // Promise<sequence<BluetoothRemoteGATTDescriptor>> getDescriptors(optional BluetoothDescriptorUUID descriptor);

+ [RaisesException, CallWith=ScriptState] Promise<BluetoothRemoteGATTDescriptor> getDescriptor(BluetoothDescriptorUUID descriptor);

+ [RaisesException, CallWith=ScriptState] Promise<sequence<BluetoothRemoteGATTDescriptor>> getDescriptors(optional BluetoothDescriptorUUID descriptor);

[CallWith=ScriptState] Promise<DataView> readValue();

[CallWith=ScriptState] Promise<void> writeValue(BufferSource value);

[CallWith=ScriptState] Promise<BluetoothRemoteGATTCharacteristic> startNotifications();