Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-invalid-name.js

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)
Patch Set: rebase to master Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-invalid-name.js
diff --git a/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-invalid-name.js b/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-invalid-name.js
new file mode 100644
index 0000000000000000000000000000000000000000..f63864b4ac673cb11a310e8bc933268e6e5d49ee
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-invalid-name.js
@@ -0,0 +1,31 @@
+'use strict';
+promise_test(() => {
+ let promise;
+ return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')
+ .then(() => requestDeviceWithKeyDown({
+ filters: [{services: ['health_thermometer']}]}))
+ .then(device => device.gatt.connect())
+ .then(gattServer => gattServer.getPrimaryService('health_thermometer'))
+ .then(service => service.getCharacteristic('measurement_interval'))
+ .then(characteristic => {
+ return assert_promise_rejects_with_message(
+ characteristic.CALLS([
+ getDescriptor('invalid-name')|
+ getDescriptors('invalid-name')[UUID]|
+ getDescriptors('invalid-name')]),
ortuno 2016/12/08 05:42:52 Remove the non [UUID] variant since it generates t
dougt 2016/12/08 08:35:59 Done.
+ new DOMException(
+ 'Failed to execute \'FUNCTION_NAME\' on ' +
+ '\'BluetoothRemoteGATTCharacteristic\': Invalid Descriptor name: ' +
+ '\'invalid-name\'. ' +
+ 'It must be a valid UUID alias (e.g. 0x1234), ' +
+ 'UUID (lowercase hex characters e.g. ' +
+ '\'00001234-0000-1000-8000-00805f9b34fb\'), ' +
+ 'or recognized standard name from ' +
+ 'https://developer.bluetooth.org/gatt/descriptors/' +
+ 'Pages/DescriptorsHomePage.aspx' +
+ ' e.g. \'gatt.characteristic_presentation_format\'.',
+ 'TypeError'));
+
+ })
+}, 'Test to ensure FUNCTION_NAME throws when called with an invalid name. ' +
+ 'Should not crash.');
ortuno 2016/12/08 05:42:52 Technically correct but not relevant for this test
dougt 2016/12/08 08:35:59 Done.

Powered by Google App Engine
This is Rietveld 408576698