Chromium Code Reviews| Index: third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-error.js |
| diff --git a/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-garbage-collection-ran-during-success.js b/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-error.js |
| similarity index 66% |
| copy from third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-garbage-collection-ran-during-success.js |
| copy to third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-error.js |
| index ad9b1ebbf71ef7b725025476d262e4c542094cec..e2417c6015173572d68f544bff7e16da22276fa9 100644 |
| --- a/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-garbage-collection-ran-during-success.js |
| +++ b/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-error.js |
| @@ -1,6 +1,5 @@ |
| 'use strict'; |
| promise_test(() => { |
| - let val = new Uint8Array([1]); |
| let promise; |
| return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter') |
| .then(() => requestDeviceWithKeyDown({ |
| @@ -8,21 +7,21 @@ promise_test(() => { |
| .then(device => device.gatt.connect()) |
| .then(gattServer => gattServer.getPrimaryService('health_thermometer')) |
| .then(service => service.getCharacteristic('measurement_interval')) |
| - .then(measurement_interval => { |
| + .then(characteristic => { |
| promise = assert_promise_rejects_with_message( |
| - measurement_interval.CALLS([ |
| - readValue()| |
| - writeValue(val)| |
| - startNotifications()| |
| - stopNotifications()]), |
| + /* 0x0101 doesn't exist in this characteristic */ |
|
ortuno
2016/12/07 08:05:12
hmm you moved this to another file but you kept th
dougt
2016/12/07 19:48:57
Done.
|
| + characteristic.CALLS([ |
| + getDescriptor(0x0101)| |
| + getDescriptors()| |
| + getDescriptors(0x0101)[UUID]]), |
| new DOMException( |
| 'GATT Server disconnected while performing a GATT operation.', |
| 'NetworkError')); |
| // Disconnect called to clear attributeInstanceMap and allow the |
| // object to get garbage collected. |
| - measurement_interval.service.device.gatt.disconnect(); |
| + characteristic.service.device.gatt.disconnect(); |
| }) |
| .then(runGarbageCollection) |
| .then(() => promise); |
| -}, 'Garbage collection ran during a FUNCTION_NAME call that succeeds. ' + |
| - 'Should not crash.'); |
| +}, 'Garbage Collection ran during FUNCTION_NAME call that fails. ' + |
| + 'Should not crash'); |