Implement WebBluetooth getDescriptor[s]

device/bluetooth/test/mock_bluetooth_gatt_characteristic.h

Index: device/bluetooth/test/mock_bluetooth_gatt_characteristic.h
diff --git a/device/bluetooth/test/mock_bluetooth_gatt_characteristic.h b/device/bluetooth/test/mock_bluetooth_gatt_characteristic.h
index 021cc599bdc42861c9ccad9f5ca812fafb0f673e..e7ca3dac804873b4ec6ff49b4a49eb71d5846a7f 100644
--- a/device/bluetooth/test/mock_bluetooth_gatt_characteristic.h
+++ b/device/bluetooth/test/mock_bluetooth_gatt_characteristic.h
@@ -12,7 +12,9 @@
 
 #include "base/callback.h"
 #include "base/macros.h"
+#include "base/memory/scoped_vector.h"
 #include "device/bluetooth/bluetooth_remote_gatt_characteristic.h"
+#include "device/bluetooth/bluetooth_remote_gatt_descriptor.h"
 #include "device/bluetooth/bluetooth_uuid.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
@@ -20,6 +22,7 @@ namespace device {
 
 class BluetoothRemoteGattDescriptor;
 class BluetoothRemoteGattService;
+class MockBluetoothGattDescriptor;
 class MockBluetoothGattService;
 
 class MockBluetoothGattCharacteristic
@@ -58,6 +61,12 @@ class MockBluetoothGattCharacteristic
                     const base::Closure&,
                     const ErrorCallback&));
 
+  void AddMockDescriptor(

[ortuno, 2016/12/07 08:05:12]

Same comment as characteristic please :p

[dougt, 2016/12/07 19:48:57]

Acknowledged.

This method only pushes a descriptor into a list.  I am not sure what kind of
comment you want, really.

[ortuno, 2016/12/08 05:42:51]

I think we want a comment about how this is supposed to be used something like:

  // BluetoothRemoteGattCharacteristic manages the lifetime of its
  // BluetoothGATTDescriptors.
  // This method takes ownership of the MockBluetoothGATTDescriptors. This
  // is only for convenience as far as testing is concerned, and it's possible
  // to write test cases without using these functions.
  // Example:
  // ON_CALL(*mock_characteristic, GetDescriptors))
  //   .WillByDefault(Invoke(
  //     *mock_characteristic,
  //      &MockBluetoothGattCharacteristic::GetMockDescriptors));

+      std::unique_ptr<MockBluetoothGattDescriptor> mock_descriptor);
+  std::vector<BluetoothRemoteGattDescriptor*> GetMockDescriptors() const;
+  BluetoothRemoteGattDescriptor* GetMockDescriptor(
+      const std::string& identifier) const;
+
  protected:
   MOCK_METHOD3(SubscribeToNotifications,
                void(BluetoothRemoteGattDescriptor*,
@@ -69,6 +78,8 @@ class MockBluetoothGattCharacteristic
                     const ErrorCallback&));
 
  private:
+  ScopedVector<MockBluetoothGattDescriptor> mock_descriptors_;
+
   DISALLOW_COPY_AND_ASSIGN(MockBluetoothGattCharacteristic);
 };