Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)
Patch Set: Updating cross-origin-objects-exceptions.html Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
index 114de82d0233a5a7a3d8eb2c15399b67154646a3..576f0d7312a1b5b603acbd9bff5ca45e8e559a99 100644
--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
@@ -332,6 +332,15 @@ class LayoutTestBluetoothAdapterProvider {
// - StartNotifySession: Run success callback.
// - GetProperties: Returns
// BluetoothRemoteGattCharacteristic::PROPERTY_READ
+ // - Descriptors
+ // - user_description
ortuno 2016/12/07 08:05:12 nit: User Description (uuid here)
dougt 2016/12/07 19:48:57 Done.
+ // Read calls success callback
ortuno 2016/12/07 08:05:12 nit: Read: Calls success callback.
dougt 2016/12/07 19:48:57 Removed. We aren't doing read or write in this cl
+ // - client_characteristic_configuration
ortuno 2016/12/07 08:05:12 nit: Client Characteristic Configuration (uuid her
dougt 2016/12/07 19:48:57 Done.
+ // Write calls success callback
ortuno 2016/12/07 08:05:12 nit: It should DCHECK since it's EXCLUDED WRITES.
dougt 2016/12/07 19:48:57 Turns out we don't do this anymore in this patch a
+ // Note: This description must be blocklist.
+ // - bad0
ortuno 2016/12/07 08:05:12 nit: Use 128bit UUIDs.
dougt 2016/12/07 19:48:57 Done.
+ // A test descriptor that does is blocklisted.
+
static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
GetDisconnectingHealthThermometer();
@@ -839,6 +848,17 @@ class LayoutTestBluetoothAdapterProvider {
// XX:XX:XX:XX:XX:XX. For example makeMACAddress(0xdeadbeef)
// returns "00:00:DE:AD:BE:EF".
static std::string makeMACAddress(uint64_t addr);
+
+ // Adds the following descriptors to the characteristic:
+ // - user_description
+ // Read calls success callback
+ // - client_characteristic_configuration
+ // Write calls success callback
+ // Note: This description must be blocklisted.
+ // - bad0
+ // Test descriptor that is blocklisted.
+ static void AddDescriptorsToCharacteristic(
+ device::MockBluetoothGattCharacteristic* characteristic);
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698