Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor-garbage-collection-ran-during-success.js

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor-garbage-collection-ran-during-success.js
diff --git a/third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-garbage-collection-ran-during-success.js b/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor-garbage-collection-ran-during-success.js
similarity index 69%
copy from third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-garbage-collection-ran-during-success.js
copy to third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor-garbage-collection-ran-during-success.js
index ad9b1ebbf71ef7b725025476d262e4c542094cec..45c8933d9565171cdf946028707f7318e5e8ce9c 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-garbage-collection-ran-during-success.js
+++ b/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor-garbage-collection-ran-during-success.js
@@ -1,6 +1,5 @@
'use strict';
promise_test(() => {
- let val = new Uint8Array([1]);
let promise;
return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')
.then(() => requestDeviceWithKeyDown({
@@ -8,21 +7,21 @@ promise_test(() => {
.then(device => device.gatt.connect())
.then(gattServer => gattServer.getPrimaryService('health_thermometer'))
.then(service => service.getCharacteristic('measurement_interval'))
- .then(measurement_interval => {
+
ortuno 2016/12/02 06:14:50 nit: Remove blank line.
dougt 2016/12/02 18:31:28 Done.
+ .then(characteristic => {
promise = assert_promise_rejects_with_message(
- measurement_interval.CALLS([
- readValue()|
- writeValue(val)|
- startNotifications()|
- stopNotifications()]),
+ characteristic.CALLS([
+ getDescriptor(user_description.name)|
+ getDescriptors()|
+ getDescriptors(user_description.name)[UUID]]),
new DOMException(
'GATT Server disconnected while performing a GATT operation.',
'NetworkError'));
// Disconnect called to clear attributeInstanceMap and allow the
// object to get garbage collected.
- measurement_interval.service.device.gatt.disconnect();
+ characteristic.service.device.gatt.disconnect();
})
.then(runGarbageCollection)
.then(() => promise);
-}, 'Garbage collection ran during a FUNCTION_NAME call that succeeds. ' +
+}, 'Garbage Collection ran during a FUNCTION_NAME call that succeeds. ' +
'Should not crash.');

Powered by Google App Engine
This is Rietveld 408576698