third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-gatt-op-garbage-collection-ran-during-error.html - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-gatt-op-garbage-collection-ran-during-error.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/test/mock_bluetooth_gatt_characteristic.h ('K') | « third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-gatt-op-disconnect-called-during-success.html ('k') | third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-gatt-op-garbage-collection-ran-during-success.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor-garbage-collection-ran-during-error.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-gatt-op-garbage-collection-ran-during-error.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-garbage-collection-ran-during-error.js b/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-gatt-op-garbage-collection-ran-during-error.html

similarity index 67%

copy from third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-garbage-collection-ran-during-error.js

copy to third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-gatt-op-garbage-collection-ran-during-error.html

index 7cb331d7a9fe092d160805668009fdeedb7ec8ff..773fdb0631e2de65308de903e2d21885c9a3107c 100644

--- a/third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-garbage-collection-ran-during-error.js

+++ b/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-gatt-op-garbage-collection-ran-during-error.html

@@ -1,3 +1,9 @@

+

+<!DOCTYPE html>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

+<script>

'use strict';

promise_test(() => {

let val = new Uint8Array([1]);

@@ -10,10 +16,7 @@ promise_test(() => {

.then(service => service.getCharacteristic(errorUUID(0xA1)))

.then(error_characteristic => {

promise = assert_promise_rejects_with_message(

- error_characteristic.CALLS([

- readValue()|

- writeValue(val)|

- startNotifications()]),

+ error_characteristic.getDescriptor(user_description.name),

new DOMException(

'GATT Server disconnected while performing a GATT operation.',

'NetworkError'));

@@ -23,5 +26,7 @@ promise_test(() => {

})

.then(runGarbageCollection)

.then(() => promise);

-}, 'Garbage Collection ran during a FUNCTION_NAME call that fails. ' +

+}, 'Garbage Collection ran during a getDescriptor call that fails. ' +

'Should not crash.');

+</script>