third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-descriptor-garbage-collection-ran-during-error.html - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-descriptor-garbage-collection-ran-during-error.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« device/bluetooth/test/mock_bluetooth_gatt_characteristic.h ('K') | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-descriptor-garbage-collection-ran-during-success.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor-garbage-collection-ran-during-error.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-descriptor-garbage-collection-ran-during-error.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-garbage-collection-ran-during-success.js b/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-descriptor-garbage-collection-ran-during-error.html

similarity index 56%

copy from third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-garbage-collection-ran-during-success.js

copy to third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-descriptor-garbage-collection-ran-during-error.html

index ad9b1ebbf71ef7b725025476d262e4c542094cec..d496bee4bb4319499db3d4b895e9ae7b9db43095 100644

--- a/third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-garbage-collection-ran-during-success.js

+++ b/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/gen-descriptor-garbage-collection-ran-during-error.html

@@ -1,6 +1,11 @@

+

+<!DOCTYPE html>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

+<script>

'use strict';

promise_test(() => {

- let val = new Uint8Array([1]);

let promise;

return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')

.then(() => requestDeviceWithKeyDown({

@@ -8,21 +13,21 @@ promise_test(() => {

.then(device => device.gatt.connect())

.then(gattServer => gattServer.getPrimaryService('health_thermometer'))

.then(service => service.getCharacteristic('measurement_interval'))

- .then(measurement_interval => {

+ .then(characteristic => {

promise = assert_promise_rejects_with_message(

- measurement_interval.CALLS([

- readValue()|

- writeValue(val)|

- startNotifications()|

- stopNotifications()]),

+ /* 0x0101 doesn't exist in this characteristic */

+ characteristic.getDescriptor(0x0101),

new DOMException(

'GATT Server disconnected while performing a GATT operation.',

'NetworkError'));

// Disconnect called to clear attributeInstanceMap and allow the

// object to get garbage collected.

- measurement_interval.service.device.gatt.disconnect();

+ characteristic.service.device.gatt.disconnect();

})

.then(runGarbageCollection)

.then(() => promise);

-}, 'Garbage collection ran during a FUNCTION_NAME call that succeeds. ' +

- 'Should not crash.');

+}, 'Garbage Collection ran during getDescriptor call that fails. ' +

+ 'Should not crash');

+</script>