Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1701)

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
index 6c9fb9ee5ec239ec38c2ded84f23fd3f141d3afc..f9319444f8adcb44163221e79676e8b3366c52dc 100644
--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
@@ -320,6 +320,13 @@ class LayoutTestBluetoothAdapterProvider {
// - StartNotifySession: Run success callback.
// - GetProperties: Returns
// BluetoothRemoteGattCharacteristic::PROPERTY_READ
+ // - Descriptors
+ // - user_description
+ // Read calls success callback
+ // - client_characteristic_configuration
+ // Write calls success callback
+ // Note: This description must be blacklisted.
ortuno 2016/12/02 06:14:50 We should make it fail like the other blacklisted
dougt 2016/12/02 18:31:28 Acknowledged blocklist name change (following what
+
static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
GetDisconnectingHealthThermometer();
@@ -827,6 +834,15 @@ class LayoutTestBluetoothAdapterProvider {
// XX:XX:XX:XX:XX:XX. For example makeMACAddress(0xdeadbeef)
// returns "00:00:DE:AD:BE:EF".
static std::string makeMACAddress(uint64_t addr);
+
+ // Adds the following descriptors to the characteristic:
+ // - user_description
+ // Read calls success callback
+ // - client_characteristic_configuration
+ // Write calls success callback
+ // Note: This description must be blacklisted.
ortuno 2016/12/02 06:14:50 We should make it fail like the other blacklisted
dougt 2016/12/02 18:31:28 Acknowledged.
+ static void AddDescriptorsToCharacteristic(
+ device::MockBluetoothGattCharacteristic* characteristic);
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698