third_party/WebKit/LayoutTests/bluetooth/getDescriptor/get-same-Descriptor.html - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/get-same-Descriptor.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Addressing code review comments from ortuno (still working on test changes) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7

	8 promise_test(() => {

	9 return setBluetoothFakeAdapter('HeartRateAdapter')

	10 .then(() => requestDeviceWithKeyDown({

	11 filters: [{services: ['heart_rate']}],

	12 optionalServices: ['generic_access']}))

	13 .then(device => device.gatt.connect())

	14 .then(gattServer => gattServer.getPrimaryService('heart_rate'))

	15 .then(service => service.getCharacteristic('heart_rate_measurement'))

	16 .then(characteristic => Promise.all([

	17 characteristic.getDescriptor(user_description.alias),

	18 characteristic.getDescriptor(user_description.alias)])

	19 .then(descriptors => {

	20 for (var i = 1; i < descriptors.length; i++) {

	21 assert_not_equals(

	22 descriptors[0], descriptors[i],

	23 'Should return the same descriptor as the first call.');

	24 }

	25 }))

	26 }, 'Calls to get the same descriptor should return the same object.');

	27 </script>

OLD	NEW