third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.idl - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.idl

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Ensure that we throw a kGattServerNotConnected error if getDescriptor[s] is called while not connec… Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp ('k') | third_party/WebKit/Source/modules/modules_idl_files.gni » ('j') | third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothRemoteGATTDescriptorInit.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://webbluetoothchrome.github.io/web-bluetooth/#idl-def-bluetoothgattdesc riptor
	ortuno 2016/11/21 03:34:09 That spec is no longer being updated use: https:/ That spec is no longer being updated use: https://webbluetoothcg.github.io/web-bluetooth/#bluetoothremotegattdescriptor dougt 2016/11/22 01:47:16 Acknowledged. Show quoted text On 2016/11/21 03:34:09, ortuno wrote: > That spec is no longer being updated use: > > https://webbluetoothcg.github.io/web-bluetooth/#bluetoothremotegattdescriptor Acknowledged.
	6

	7 // Implement BluetoothRemoteGATTDescriptor interface: https://crbug.com/660699

	8

	9 [

	10 DependentLifetime,

	11 RuntimeEnabled=WebBluetooth,

	12 ] interface BluetoothRemoteGATTDescriptor : EventTarget {//: DescriptorEventHand lers {
	ortuno 2016/11/21 03:34:09 There are no descriptor events so no need for Even There are no descriptor events so no need for EventTarget. dougt 2016/11/22 01:47:16 Acknowledged. Show quoted text On 2016/11/21 03:34:09, ortuno wrote: > There are no descriptor events so no need for EventTarget. Acknowledged.
	13

	14

	15 readonly attribute BluetoothRemoteGATTCharacteristic characteristic;

	16 readonly attribute UUID uuid;

	17 readonly attribute DataView? value;

	18 [CallWith=ScriptState] Promise<DataView> readValue( );
	ortuno 2016/11/21 03:34:09 nit: Line the names up. nit: Line the names up. dougt 2016/11/22 01:47:16 Acknowledged. Show quoted text On 2016/11/21 03:34:09, ortuno wrote: > nit: Line the names up. Acknowledged.
	19 [CallWith=ScriptState] Promise<void> writeValue (BufferSource value);

	20

	21 // TODO(dft): Move this to DescriptorEventHandlers.

	22 // http://crbug.com/XXXXX

	23 attribute EventHandler ondescriptorvaluechanged;

	24 };

OLD	NEW