third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-blacklisted.html - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-blacklisted.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Ensure that we throw a kGattServerNotConnected error if getDescriptor[s] is called while not connec… Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« device/bluetooth/test/mock_bluetooth_gatt_characteristic.h ('K') | « device/bluetooth/test/mock_bluetooth_gatt_characteristic.cc ('k') | third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	ortuno 2016/11/21 03:34:09 Can you change the name to descriptor-write-blackl Can you change the name to descriptor-write-blacklisted.html dougt 2016/11/22 01:47:16 Acknowledged. Show quoted text On 2016/11/21 03:34:09, ortuno wrote: > Can you change the name to descriptor-write-blacklisted.html Acknowledged.
	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7

	8 promise_test(() => {

	9 return setBluetoothFakeAdapter('HeartRateAdapter')

	10 .then(() => requestDeviceWithKeyDown({

	11 filters: [{services: ['heart_rate']}],

	12 optionalServices: ['generic_access']}))

	13 .then(device => device.gatt.connect())

	14 .then(gattServer => gattServer.getPrimaryService('heart_rate'))

	15 .then(service => service.getCharacteristic('heart_rate_measurement'))

	16 // This UUID is for the client config which is black listed on write.

	17 .then(characteristic => characteristic.getDescriptor("00002902-0000-1000-800 0-00805f9b34fb"))
	ortuno 2016/11/21 03:34:08 No need for the whole UUID since it's a standard U No need for the whole UUID since it's a standard UUID: 'gatt.characteristic_user_description' should be enough. dougt 2016/11/22 01:47:16 Acknowledged. Show quoted text On 2016/11/21 03:34:08, ortuno wrote: > No need for the whole UUID since it's a standard UUID: > 'gatt.characteristic_user_description' should be enough. Acknowledged.
	18 .then(descriptor => {

	19 assert_promise_rejects_with_message(
	ortuno 2016/11/21 03:34:08 Either return or don't use '{' so that it's implic Either return or don't use '{' so that it's implicitly returned. Otherwise the test is not going to fail because the promise is not being chained. dougt 2016/11/22 01:47:16 Acknowledged. Show quoted text On 2016/11/21 03:34:08, ortuno wrote: > Either return or don't use '{' so that it's implicitly returned. Otherwise the > test is not going to fail because the promise is not being chained. Acknowledged.
	20 descriptor.writeValue(new Uint8Array(1)),
	ortuno 2016/11/21 03:34:08 Also add a test for excluded-read. There is an exc Also add a test for excluded-read. There is an excluded-read descriptor already: https://cs.chromium.org/chromium/src/content/browser/bluetooth/bluetooth_blac...
	21 new DOMException(

	22 'writeValue() called on blacklisted object marked exclude-writes.' +

	23 ' https://goo.gl/4NeimX',

	24 'SecurityError'),

	25 'writeValue() should reject.')

	26 })

	27 }, 'Blacklisted writes must fail.');

	28 </script>

OLD	NEW