Implement WebBluetooth getDescriptor[s]

third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BluetoothDevice_h
 #define BluetoothDevice_h
 
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "core/dom/ContextLifecycleObserver.h"
 #include "modules/EventTargetModules.h"
 #include "modules/bluetooth/BluetoothRemoteGATTServer.h"
 #include "platform/heap/Heap.h"
 #include "public/platform/modules/bluetooth/WebBluetoothDevice.h"
 #include "public/platform/modules/bluetooth/WebBluetoothDeviceInit.h"
 #include "wtf/text/WTFString.h"
 #include <memory>
 
 namespace blink {
 
 class BluetoothAttributeInstanceMap;
 class BluetoothRemoteGATTCharacteristic;
+class BluetoothRemoteGATTDescriptor;
 class BluetoothRemoteGATTServer;
 class BluetoothRemoteGATTService;
 class ScriptPromiseResolver;
 
 struct WebBluetoothRemoteGATTCharacteristicInit;
+struct WebBluetoothRemoteGATTDescriptorInit;
 struct WebBluetoothRemoteGATTService;
 
 // BluetoothDevice represents a physical bluetooth device in the DOM. See IDL.
 //
 // Callbacks providing WebBluetoothDevice objects are handled by
 // CallbackPromiseAdapter templatized with this class. See this class's
 // "Interface required by CallbackPromiseAdapter" section and the
 // CallbackPromiseAdapter class comments.
 class BluetoothDevice final : public EventTargetWithInlineData,
                               public ContextLifecycleObserver,
@@ skipping 14 matching lines @@
       std::unique_ptr<WebBluetoothRemoteGATTService>);
   bool isValidService(const String& serviceInstanceId);
 
   BluetoothRemoteGATTCharacteristic*
   getOrCreateBluetoothRemoteGATTCharacteristic(
       ExecutionContext*,
       std::unique_ptr<WebBluetoothRemoteGATTCharacteristicInit>,
       BluetoothRemoteGATTService*);
   bool isValidCharacteristic(const String& characteristicInstanceId);
 
+  BluetoothRemoteGATTDescriptor* getOrCreateBluetoothRemoteGATTDescriptor(
+      std::unique_ptr<WebBluetoothRemoteGATTDescriptorInit>,
+      BluetoothRemoteGATTCharacteristic*);
+  bool isValidDescriptor(const String& descriptorInstanceId);

[dcheng, 2016/12/09 08:17:57]

I might be missing something, but this doesn't appear to be called?

[dougt, 2016/12/09 19:20:06]

removed.  this is work for descriptor readValue/writeValue methods which were
teased out of this CL.  I'll remove here.

+
   // We should disconnect from the device in all of the following cases:
   // 1. When the object gets GarbageCollected e.g. it went out of scope.
   // dispose() is called in this case.
   // 2. When the parent document gets detached e.g. reloading a page.
   // stop() is called in this case.
   // TODO(ortuno): Users should be able to turn on notifications for
   // events on navigator.bluetooth and still remain connected even if the
   // BluetoothDevice object is garbage collected.
 
   // USING_PRE_FINALIZER interface.
@@ skipping 34 matching lines @@
   // Holds all GATT Attributes associated with this BluetoothDevice.
   Member<BluetoothAttributeInstanceMap> m_attributeInstanceMap;
 
   std::unique_ptr<WebBluetoothDeviceInit> m_webDevice;
   Member<BluetoothRemoteGATTServer> m_gatt;
 };
 
 }  // namespace blink
 
 #endif  // BluetoothDevice_h