third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/blocklisted-descriptors-not-present.html - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/blocklisted-descriptors-not-present.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: rebase to master Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-service-is-removed.html ('k') | third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7 promise_test(() => {

	8 // DisconnectingHealthThermometerAdapter's measurement_interval contains

	9 // one blocklisted descriptor. Make sure that it isn't returned in the result

	10 // of getDescriptors().

	11 return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')

	12 .then(() => requestDeviceWithKeyDown({

	13 filters: [{services: ['health_thermometer']}]}))

	14 .then(device => device.gatt.connect())

	15 .then(gattServer => gattServer.getPrimaryService('health_thermometer'))

	16 .then(service => service.getCharacteristic('measurement_interval'))

	17 .then(characteristic => characteristic.getDescriptors())

	18 .then(descriptors => {

	19 descriptors.forEach(

	20 descriptor => {
	ortuno 2016/12/08 05:42:51 nit: Move to previous line. nit: Move to previous line. dougt 2016/12/08 08:35:58 Done. Show quoted text On 2016/12/08 05:42:51, ortuno wrote: > nit: Move to previous line. Done.
	21 let bad_uuid = 'bad2ddcf-60db-45cd-bef9-fd72b153cf7c';
	ortuno 2016/12/08 05:42:51 nit: Move this to resources. https://cs.chromium.o nit: Move this to resources. https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources... dougt 2016/12/08 08:35:58 Done. Show quoted text On 2016/12/08 05:42:51, ortuno wrote: > nit: Move this to resources. > https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources... Done.
	22 // bad_uuid is a blocklisted UUID. It should never be present

	23 // in a getDescriptors() result.

	24 assert_true(descriptor.uuid != bad_uuid)

	25 });

	26 })

	27 }, 'Making sure no blocklisted descriptors are present. ');

	28

	29

	30 </script>

OLD	NEW