Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 'use strict'; | 1 'use strict'; |
| 2 promise_test(() => { | 2 promise_test(() => { |
| 3 let val = new Uint8Array([1]); | |
| 4 let promise; | 3 let promise; |
| 5 return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter') | 4 return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter') |
| 6 .then(() => requestDeviceWithKeyDown({ | 5 .then(() => requestDeviceWithKeyDown({ |
| 7 filters: [{services: ['health_thermometer']}]})) | 6 filters: [{services: ['health_thermometer']}]})) |
| 8 .then(device => device.gatt.connect()) | 7 .then(device => device.gatt.connect()) |
| 9 .then(gattServer => gattServer.getPrimaryService('health_thermometer')) | 8 .then(gattServer => gattServer.getPrimaryService('health_thermometer')) |
| 10 .then(service => service.getCharacteristic('measurement_interval')) | 9 .then(service => service.getCharacteristic('measurement_interval')) |
| 11 .then(measurement_interval => { | 10 .then(characteristic => { |
| 12 promise = assert_promise_rejects_with_message( | 11 promise = assert_promise_rejects_with_message( |
| 13 measurement_interval.CALLS([ | 12 characteristic.CALLS([ |
|
ortuno
2016/12/07 08:05:12
Same here, either change the error message or move
dougt
2016/12/07 19:48:57
Done.
| |
| 14 readValue()| | 13 getDescriptor(user_description.name)| |
| 15 writeValue(val)| | 14 getDescriptors()| |
| 16 startNotifications()| | 15 getDescriptors(user_description.name)[UUID]]), |
| 17 stopNotifications()]), | |
| 18 new DOMException( | 16 new DOMException( |
| 19 'GATT Server disconnected while performing a GATT operation.', | 17 'GATT Server disconnected while performing a GATT operation.', |
| 20 'NetworkError')); | 18 'NetworkError')); |
| 21 // Disconnect called to clear attributeInstanceMap and allow the | 19 // Disconnect called to clear attributeInstanceMap and allow the |
| 22 // object to get garbage collected. | 20 // object to get garbage collected. |
| 23 measurement_interval.service.device.gatt.disconnect(); | 21 characteristic.service.device.gatt.disconnect(); |
| 24 }) | 22 }) |
| 25 .then(runGarbageCollection) | 23 .then(runGarbageCollection) |
| 26 .then(() => promise); | 24 .then(() => promise); |
| 27 }, 'Garbage collection ran during a FUNCTION_NAME call that succeeds. ' + | 25 }, 'Garbage Collection ran during a FUNCTION_NAME call that succeeds. ' + |
| 28 'Should not crash.'); | 26 'Should not crash.'); |
| OLD | NEW |