Implement WebBluetooth getDescriptor[s]

content/browser/bluetooth/bluetooth_metrics.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/bluetooth/bluetooth_metrics.h"
 
 #include <stdint.h>
 
 #include <map>
 #include <set>
@@ skipping 213 matching lines @@
       return;
     case CacheQueryOutcome::NO_DEVICE:
       RecordGetCharacteristicsOutcome(quantity,
                                       UMAGetCharacteristicOutcome::NO_DEVICE);
       return;
     case CacheQueryOutcome::NO_SERVICE:
       RecordGetCharacteristicsOutcome(quantity,
                                       UMAGetCharacteristicOutcome::NO_SERVICE);
       return;
     case CacheQueryOutcome::NO_CHARACTERISTIC:
+    case CacheQueryOutcome::NO_DESCRIPTOR:

[ortuno, 2016/12/02 06:14:49]

nit: Similarly here. I don't think we need these changes in this patch.

[dougt, 2016/12/02 18:31:27]

Done.

       NOTREACHED();
       return;
   }
 }
 
 void RecordGetCharacteristicsCharacteristic(
     blink::mojom::WebBluetoothGATTQueryQuantity quantity,
     const base::Optional<BluetoothUUID>& characteristic) {
   switch (quantity) {
     case blink::mojom::WebBluetoothGATTQueryQuantity::SINGLE:
@@ skipping 16 matching lines @@
   switch (operation) {
     case UMAGATTOperation::CHARACTERISTIC_READ:
       RecordCharacteristicReadValueOutcome(outcome);
       return;
     case UMAGATTOperation::CHARACTERISTIC_WRITE:
       RecordCharacteristicWriteValueOutcome(outcome);
       return;
     case UMAGATTOperation::START_NOTIFICATIONS:
       RecordStartNotificationsOutcome(outcome);
       return;
+    case UMAGATTOperation::DESCRIPTOR_READ:
+    case UMAGATTOperation::DESCRIPTOR_WRITE:
+      // TODO(crbug.com/667319): Record descriptor interactions.
+      return;
     case UMAGATTOperation::COUNT:
       NOTREACHED();
       return;
   }
   NOTREACHED();
 }
 
 static UMAGATTOperationOutcome TranslateCacheQueryOutcomeToGATTOperationOutcome(
     CacheQueryOutcome outcome) {
   switch (outcome) {
     case CacheQueryOutcome::SUCCESS:
     case CacheQueryOutcome::BAD_RENDERER:
       // No need to record a success or renderer crash.
       NOTREACHED();
       return UMAGATTOperationOutcome::NOT_SUPPORTED;
     case CacheQueryOutcome::NO_DEVICE:
       return UMAGATTOperationOutcome::NO_DEVICE;
     case CacheQueryOutcome::NO_SERVICE:
       return UMAGATTOperationOutcome::NO_SERVICE;
     case CacheQueryOutcome::NO_CHARACTERISTIC:
       return UMAGATTOperationOutcome::NO_CHARACTERISTIC;
+    case CacheQueryOutcome::NO_DESCRIPTOR:
+      return UMAGATTOperationOutcome::NO_DESCRIPTOR;
   }
   NOTREACHED() << "No need to record success or renderer crash";
   return UMAGATTOperationOutcome::NOT_SUPPORTED;
 }
 
 // Characteristic.readValue
 
 // static
 void RecordCharacteristicReadValueOutcome(UMAGATTOperationOutcome outcome) {
   UMA_HISTOGRAM_ENUMERATION("Bluetooth.Web.Characteristic.ReadValue.Outcome",
@@ skipping 38 matching lines @@
 }
 
 void RecordRSSISignalStrengthLevel(UMARSSISignalStrengthLevel level) {
   UMA_HISTOGRAM_ENUMERATION(
       "Bluetooth.Web.RequestDevice.RSSISignalStrengthLevel",
       static_cast<int>(level),
       static_cast<int>(UMARSSISignalStrengthLevel::COUNT));
 }
 
 }  // namespace content