Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2466163002: [Devtools] Fixed contextmenu double showing for network requests (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @param {!WebInspector.NetworkLogView} networkLogView 7 * @param {!WebInspector.NetworkLogView} networkLogView
8 * @param {!WebInspector.NetworkTransferTimeCalculator} timeCalculator 8 * @param {!WebInspector.NetworkTransferTimeCalculator} timeCalculator
9 * @param {!WebInspector.NetworkTransferDurationCalculator} durationCalculator 9 * @param {!WebInspector.NetworkTransferDurationCalculator} durationCalculator
10 * @param {!WebInspector.Setting} networkLogLargeRowsSetting 10 * @param {!WebInspector.Setting} networkLogLargeRowsSetting
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 * @param {!Event} event 490 * @param {!Event} event
491 * @this {WebInspector.NetworkLogViewColumns} 491 * @this {WebInspector.NetworkLogViewColumns}
492 */ 492 */
493 function handleContextMenu(event) 493 function handleContextMenu(event)
494 { 494 {
495 var request = this._timelineColumn.getRequestFromPoint(event.offsetX , event.offsetY); 495 var request = this._timelineColumn.getRequestFromPoint(event.offsetX , event.offsetY);
496 if (!request) 496 if (!request)
497 return; 497 return;
498 var contextMenu = new WebInspector.ContextMenu(event); 498 var contextMenu = new WebInspector.ContextMenu(event);
499 this._networkLogView.handleContextMenuForRequest(contextMenu, reques t); 499 this._networkLogView.handleContextMenuForRequest(contextMenu, reques t);
500 contextMenu.show();
500 } 501 }
501 }, 502 },
502 503
503 /** 504 /**
504 * @param {boolean} shouldConsume 505 * @param {boolean} shouldConsume
505 * @param {!Event} event 506 * @param {!Event} event
506 */ 507 */
507 _onMouseWheel: function(shouldConsume, event) 508 _onMouseWheel: function(shouldConsume, event)
508 { 509 {
509 if (shouldConsume) 510 if (shouldConsume)
(...skipping 606 matching lines...) Expand 10 before | Expand all | Expand 10 after
1116 { 1117 {
1117 if (Runtime.experiments.isEnabled("canvasNetworkTimeline")) { 1118 if (Runtime.experiments.isEnabled("canvasNetworkTimeline")) {
1118 this._shownEventDividers.delete(WebInspector.NetworkLogViewColumns._ filmStripDividerColor); 1119 this._shownEventDividers.delete(WebInspector.NetworkLogViewColumns._ filmStripDividerColor);
1119 this._redrawTimelineColumn(); 1120 this._redrawTimelineColumn();
1120 return; 1121 return;
1121 } 1122 }
1122 for (var divider of this._eventDividers) 1123 for (var divider of this._eventDividers)
1123 divider.element.classList.toggle("network-frame-divider-selected", f alse); 1124 divider.element.classList.toggle("network-frame-divider-selected", f alse);
1124 } 1125 }
1125 }; 1126 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698