Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2466163002: [Devtools] Fixed contextmenu double showing for network requests (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 926 matching lines...) Expand 10 before | Expand all | Expand 10 after
937 blockedSetting.set(list); 937 blockedSetting.set(list);
938 WebInspector.viewManager.showView("network.blocked-urls"); 938 WebInspector.viewManager.showView("network.blocked-urls");
939 } 939 }
940 } 940 }
941 941
942 if (request && request.resourceType() === WebInspector.resourceTypes.XHR ) { 942 if (request && request.resourceType() === WebInspector.resourceTypes.XHR ) {
943 contextMenu.appendSeparator(); 943 contextMenu.appendSeparator();
944 contextMenu.appendItem(WebInspector.UIString("Replay XHR"), request. replayXHR.bind(request)); 944 contextMenu.appendItem(WebInspector.UIString("Replay XHR"), request. replayXHR.bind(request));
945 contextMenu.appendSeparator(); 945 contextMenu.appendSeparator();
946 } 946 }
947
948 contextMenu.show();
949 }, 947 },
950 948
951 _harRequests: function() 949 _harRequests: function()
952 { 950 {
953 var requests = this._nodesByRequestId.valuesArray().map(function(node) { return node.request(); }); 951 var requests = this._nodesByRequestId.valuesArray().map(function(node) { return node.request(); });
954 var httpRequests = requests.filter(WebInspector.NetworkLogView.HTTPReque stsFilter); 952 var httpRequests = requests.filter(WebInspector.NetworkLogView.HTTPReque stsFilter);
955 return httpRequests.filter(WebInspector.NetworkLogView.FinishedRequestsF ilter); 953 return httpRequests.filter(WebInspector.NetworkLogView.FinishedRequestsF ilter);
956 }, 954 },
957 955
958 _copyAll: function() 956 _copyAll: function()
(...skipping 809 matching lines...) Expand 10 before | Expand all | Expand 10 after
1768 * @return {boolean} 1766 * @return {boolean}
1769 */ 1767 */
1770 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request) 1768 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request)
1771 { 1769 {
1772 if (request.issueTime() > windowEnd) 1770 if (request.issueTime() > windowEnd)
1773 return false; 1771 return false;
1774 if (request.endTime !== -1 && request.endTime < windowStart) 1772 if (request.endTime !== -1 && request.endTime < windowStart)
1775 return false; 1773 return false;
1776 return true; 1774 return true;
1777 }; 1775 };
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698