Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2466163002: [Devtools] Fixed contextmenu double showing for network requests (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed contextmenu double showing for network requests This patch fixes a regression caused from https://codereview.chromium.org/2447933002/ where it would try and show the menu twice. R=dgozman BUG=660998 Committed: https://crrev.com/364ca9775ffda6909ea0126343d3c0a7458321f7 Cr-Commit-Position: refs/heads/master@{#428919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
allada
PTL
4 years, 1 month ago (2016-11-01 00:00:49 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-01 00:07:47 UTC) #4
dgozman
On 2016/11/01 00:07:47, dgozman wrote: > lgtm Did the same happen to other clients of ...
4 years, 1 month ago (2016-11-01 00:08:16 UTC) #5
allada
On 2016/11/01 00:08:16, dgozman wrote: > On 2016/11/01 00:07:47, dgozman wrote: > > lgtm > ...
4 years, 1 month ago (2016-11-01 00:25:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466163002/1
4 years, 1 month ago (2016-11-01 01:32:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 02:51:05 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 02:53:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/364ca9775ffda6909ea0126343d3c0a7458321f7
Cr-Commit-Position: refs/heads/master@{#428919}

Powered by Google App Engine
This is Rietveld 408576698