ios/web/web_state/ui/crw_web_controller.h - Issue 2466143002: iOS: Mark HTTP pages with password fields with an omnibox icon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.h

Issue 2466143002: iOS: Mark HTTP pages with password fields with an omnibox icon. (Closed)

Patch Set: iOS HTTP Bad. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.h

diff --git a/ios/web/web_state/ui/crw_web_controller.h b/ios/web/web_state/ui/crw_web_controller.h

index 8bbb8d8ba5e0eec962f34fec87a64501e151ee31..0d7c47fd30e49e179bba84ed0a5e2864ac006040 100644

--- a/ios/web/web_state/ui/crw_web_controller.h

+++ b/ios/web/web_state/ui/crw_web_controller.h

@@ -232,6 +232,8 @@ class WebStateImpl;

// Notifies the CRWWebController that it has been shown.

- (void)wasShown;

+- (void)didShowSensitiveInputOnHttp;

lgarron 2016/11/29 03:48:49 Is this the appropriate way to adapt OnSensitiveIn

Eugene But (OOO till 7-30) 2016/11/30 17:58:41 Please add comments.

Eugene But (OOO till 7-30) 2016/11/30 17:58:41 The naming pattern is correct. Please use all caps

lgarron 2016/12/02 01:21:52 Done.

// Notifies the CRWWebController that it has been hidden.

- (void)wasHidden;