iOS: Mark HTTP pages with password fields with an omnibox icon.

ios/chrome/browser/ssl/ios_security_state_tab_helper.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/ssl/ios_security_state_tab_helper.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/field_trial.h"
@@ skipping 37 matching lines @@
   state->connection_info_initialized = true;
   state->url = item->GetURL();
   const web::SSLStatus& ssl = item->GetSSL();
   state->certificate = ssl.certificate;
   state->cert_status = ssl.cert_status;
   state->connection_status = ssl.connection_status;
   state->security_bits = ssl.security_bits;
   state->displayed_mixed_content =
       (ssl.content_status & web::SSLStatus::DISPLAYED_INSECURE_CONTENT) ? true
                                                                         : false;
+  state->displayed_password_field_on_http =
+      (ssl.content_status & web::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP)
+          ? true

[Eugene But (OOO till 7-30), 2016/11/30 17:58:41]

nit: do you need ternary here? |ssl.content_status &
web::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP| perfectly converts to bool

[lgarron, 2016/12/02 01:21:52]

I copied state->displayed_mixed_content for consistency.
Should I be inconsistent (or convert state->displayed_mixed_content)?

[Eugene But (OOO till 7-30), 2016/12/02 01:53:11]

Sorry, did not notice the previous line :) Feel free to leave as it is or remove
ternary from both places. It's up to you.

+          : false;
   return state;
 }