iOS: Mark HTTP pages with password fields with an omnibox icon.

ios/chrome/browser/passwords/password_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/passwords/password_controller.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <map>
@@ skipping 24 matching lines @@
 #include "ios/chrome/browser/experimental_flags.h"
 #include "ios/chrome/browser/infobars/infobar_manager_impl.h"
 #import "ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h"
 #import "ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h"
 #import "ios/chrome/browser/passwords/js_password_manager.h"
 #import "ios/chrome/browser/passwords/password_generation_agent.h"
 #include "ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h"
 #include "ios/web/public/url_scheme_util.h"
 #import "ios/web/public/web_state/js/crw_js_injection_receiver.h"
 #import "ios/web/public/web_state/web_state.h"
+#include "ios/web/web_state/web_state_impl.h"

[lgarron, 2016/11/29 03:48:49]

This is giving me:

    You added one or more #includes that violate checkdeps rules.
      ios/chrome/browser/passwords/password_controller.mm
          Illegal include: "ios/web/web_state/web_state_impl.h"

Should we update the deps, or do I need to work around this?

[estark, 2016/11/29 21:28:48]

I'm guessing ios/chrome is only allowed to depend on public ios/web interfaces,
just as //chrome is only allowed to depend on //content/public.

Can you instead move the OnSensitiveInputShownOnHttp method on to the public
WebState interface in ios/web/public/web_state/web_state.h?

[Eugene But (OOO till 7-30), 2016/11/30 17:58:41]

Yep, ios/chrome can not depend on non-public ios/web. Same as for content.

[lgarron, 2016/12/02 01:21:52]

I've added it to the public interface (and removed the static_cast in below in
this file.)

 #include "url/gurl.h"
 
 using password_manager::PasswordFormManager;
 using password_manager::PasswordGenerationManager;
 using password_manager::PasswordManager;
 using password_manager::PasswordManagerClient;
 using password_manager::PasswordManagerDriver;
 
 namespace {
 // Types of password infobars to display.
@@ skipping 486 matching lines @@
                        pageURL:pageURL];
 }
 
 - (void)didFinishPasswordFormExtraction:
     (const std::vector<autofill::PasswordForm>&)forms {
   // Do nothing if |self| has been detached.
   if (!passwordManager_)
     return;
 
   if (!forms.empty()) {
+    // Notify web_state about password forms, so that this can be taken into
+    // account for the security

[estark, 2016/11/29 21:28:48]

nit: unfinished sentence?

[lgarron, 2016/12/02 01:21:52]

Fixed.

+    if (webStateObserverBridge_ && webStateObserverBridge_->web_state()) {
+      // TODO: Only do this for HTTP.

[lgarron, 2016/11/29 03:48:49]

Note: Haven't gotten to this, since it's the "easy" part.

[lgarron, 2016/12/02 01:21:52]

Done.

+      static_cast<web::WebStateImpl*>(webStateObserverBridge_->web_state())
+          ->OnSensitiveInputShownOnHttp();
+    }
+
     // Invoke the password manager callback to autofill password forms
     // on the loaded page.
     passwordManager_->OnPasswordFormsParsed(passwordManagerDriver_.get(),
                                             forms);
 
     // Pass the forms to PasswordGenerationAgent to look for account creation
     // forms with local heuristics.
     [passwordGenerationAgent_ processParsedPasswordForms:forms];
   }
   // Invoke the password manager callback to check if password was
@@ skipping 304 matching lines @@
       break;
 
     case PasswordInfoBarType::UPDATE:
       IOSChromeUpdatePasswordInfoBarDelegate::Create(
           isSmartLockBrandingEnabled, infoBarManager, std::move(form));
       break;
   }
 }
 
 @end