Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
index 0e09b19d7c0de1f530fc4b8e4e1deae9d219bc01..8ab49419e6d5ce03ce7215ba603c6a01139bcc54 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
@@ -27,235 +27,225 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-
/**
- * @constructor
- * @extends {WebInspector.VBox}
* @implements {WebInspector.TargetManager.Observer}
- * @param {!WebInspector.ProfilesPanel} profilesPanel
+ * @unrestricted
*/
-WebInspector.ProfileLauncherView = function(profilesPanel)
-{
- WebInspector.VBox.call(this);
+WebInspector.ProfileLauncherView = class extends WebInspector.VBox {
+ /**
+ * @param {!WebInspector.ProfilesPanel} profilesPanel
+ */
+ constructor(profilesPanel) {
+ super();
this._panel = profilesPanel;
- this.element.classList.add("profile-launcher-view");
- this.element.classList.add("panel-enabler-view");
+ this.element.classList.add('profile-launcher-view');
+ this.element.classList.add('panel-enabler-view');
- this._contentElement = this.element.createChild("div", "profile-launcher-view-content");
- this._innerContentElement = this._contentElement.createChild("div");
- var targetSpan = this._contentElement.createChild("span");
- var selectTargetText = targetSpan.createChild("span");
- selectTargetText.textContent = WebInspector.UIString("Target:");
- var targetsSelect = targetSpan.createChild("select", "chrome-select");
+ this._contentElement = this.element.createChild('div', 'profile-launcher-view-content');
+ this._innerContentElement = this._contentElement.createChild('div');
+ var targetSpan = this._contentElement.createChild('span');
+ var selectTargetText = targetSpan.createChild('span');
+ selectTargetText.textContent = WebInspector.UIString('Target:');
+ var targetsSelect = targetSpan.createChild('select', 'chrome-select');
new WebInspector.TargetsComboBoxController(targetsSelect, targetSpan);
- this._controlButton = createTextButton("", this._controlButtonClicked.bind(this), "control-profiling");
+ this._controlButton = createTextButton('', this._controlButtonClicked.bind(this), 'control-profiling');
this._contentElement.appendChild(this._controlButton);
this._recordButtonEnabled = true;
- this._loadButton = createTextButton(WebInspector.UIString("Load"), this._loadButtonClicked.bind(this), "load-profile");
+ this._loadButton =
+ createTextButton(WebInspector.UIString('Load'), this._loadButtonClicked.bind(this), 'load-profile');
this._contentElement.appendChild(this._loadButton);
WebInspector.targetManager.observeTargets(this);
+ }
+
+ /**
+ * @return {?WebInspector.SearchableView}
+ */
+ searchableView() {
+ return null;
+ }
+
+ /**
+ * @override
+ * @param {!WebInspector.Target} target
+ */
+ targetAdded(target) {
+ this._updateLoadButtonLayout();
+ }
+
+ /**
+ * @override
+ * @param {!WebInspector.Target} target
+ */
+ targetRemoved(target) {
+ this._updateLoadButtonLayout();
+ }
+
+ _updateLoadButtonLayout() {
+ this._loadButton.classList.toggle(
+ 'multi-target', WebInspector.targetManager.targets(WebInspector.Target.Capability.JS).length > 1);
+ }
+
+ /**
+ * @param {!WebInspector.ProfileType} profileType
+ */
+ addProfileType(profileType) {
+ var descriptionElement = this._innerContentElement.createChild('h1');
+ descriptionElement.textContent = profileType.description;
+ var decorationElement = profileType.decorationElement();
+ if (decorationElement)
+ this._innerContentElement.appendChild(decorationElement);
+ this._isInstantProfile = profileType.isInstantProfile();
+ this._isEnabled = profileType.isEnabled();
+ }
+
+ _controlButtonClicked() {
+ this._panel.toggleRecord();
+ }
+
+ _loadButtonClicked() {
+ this._panel.showLoadFromFileDialog();
+ }
+
+ _updateControls() {
+ if (this._isEnabled && this._recordButtonEnabled)
+ this._controlButton.removeAttribute('disabled');
+ else
+ this._controlButton.setAttribute('disabled', '');
+ this._controlButton.title = this._recordButtonEnabled ? '' : WebInspector.anotherProfilerActiveLabel();
+ if (this._isInstantProfile) {
+ this._controlButton.classList.remove('running');
+ this._controlButton.textContent = WebInspector.UIString('Take Snapshot');
+ } else if (this._isProfiling) {
+ this._controlButton.classList.add('running');
+ this._controlButton.textContent = WebInspector.UIString('Stop');
+ } else {
+ this._controlButton.classList.remove('running');
+ this._controlButton.textContent = WebInspector.UIString('Start');
+ }
+ }
+
+ profileStarted() {
+ this._isProfiling = true;
+ this._updateControls();
+ }
+
+ profileFinished() {
+ this._isProfiling = false;
+ this._updateControls();
+ }
+
+ /**
+ * @param {!WebInspector.ProfileType} profileType
+ * @param {boolean} recordButtonEnabled
+ */
+ updateProfileType(profileType, recordButtonEnabled) {
+ this._isInstantProfile = profileType.isInstantProfile();
+ this._recordButtonEnabled = recordButtonEnabled;
+ this._isEnabled = profileType.isEnabled();
+ this._updateControls();
+ }
};
-WebInspector.ProfileLauncherView.prototype = {
- /**
- * @return {?WebInspector.SearchableView}
- */
- searchableView: function()
- {
- return null;
- },
-
- /**
- * @override
- * @param {!WebInspector.Target} target
- */
- targetAdded: function(target)
- {
- this._updateLoadButtonLayout();
- },
-
- /**
- * @override
- * @param {!WebInspector.Target} target
- */
- targetRemoved: function(target)
- {
- this._updateLoadButtonLayout();
- },
-
- _updateLoadButtonLayout: function()
- {
- this._loadButton.classList.toggle("multi-target", WebInspector.targetManager.targets(WebInspector.Target.Capability.JS).length > 1);
- },
-
- /**
- * @param {!WebInspector.ProfileType} profileType
- */
- addProfileType: function(profileType)
- {
- var descriptionElement = this._innerContentElement.createChild("h1");
- descriptionElement.textContent = profileType.description;
- var decorationElement = profileType.decorationElement();
- if (decorationElement)
- this._innerContentElement.appendChild(decorationElement);
- this._isInstantProfile = profileType.isInstantProfile();
- this._isEnabled = profileType.isEnabled();
- },
-
- _controlButtonClicked: function()
- {
- this._panel.toggleRecord();
- },
-
- _loadButtonClicked: function()
- {
- this._panel.showLoadFromFileDialog();
- },
-
- _updateControls: function()
- {
- if (this._isEnabled && this._recordButtonEnabled)
- this._controlButton.removeAttribute("disabled");
- else
- this._controlButton.setAttribute("disabled", "");
- this._controlButton.title = this._recordButtonEnabled ? "" : WebInspector.anotherProfilerActiveLabel();
- if (this._isInstantProfile) {
- this._controlButton.classList.remove("running");
- this._controlButton.textContent = WebInspector.UIString("Take Snapshot");
- } else if (this._isProfiling) {
- this._controlButton.classList.add("running");
- this._controlButton.textContent = WebInspector.UIString("Stop");
- } else {
- this._controlButton.classList.remove("running");
- this._controlButton.textContent = WebInspector.UIString("Start");
- }
- },
-
- profileStarted: function()
- {
- this._isProfiling = true;
- this._updateControls();
- },
-
- profileFinished: function()
- {
- this._isProfiling = false;
- this._updateControls();
- },
-
- /**
- * @param {!WebInspector.ProfileType} profileType
- * @param {boolean} recordButtonEnabled
- */
- updateProfileType: function(profileType, recordButtonEnabled)
- {
- this._isInstantProfile = profileType.isInstantProfile();
- this._recordButtonEnabled = recordButtonEnabled;
- this._isEnabled = profileType.isEnabled();
- this._updateControls();
- },
-
- __proto__: WebInspector.VBox.prototype
-};
-
-
/**
- * @constructor
- * @extends {WebInspector.ProfileLauncherView}
- * @param {!WebInspector.ProfilesPanel} profilesPanel
+ * @unrestricted
*/
-WebInspector.MultiProfileLauncherView = function(profilesPanel)
-{
- WebInspector.ProfileLauncherView.call(this, profilesPanel);
+WebInspector.MultiProfileLauncherView = class extends WebInspector.ProfileLauncherView {
+ /**
+ * @param {!WebInspector.ProfilesPanel} profilesPanel
+ */
+ constructor(profilesPanel) {
+ super(profilesPanel);
- this._selectedProfileTypeSetting = WebInspector.settings.createSetting("selectedProfileType", "CPU");
+ this._selectedProfileTypeSetting = WebInspector.settings.createSetting('selectedProfileType', 'CPU');
- var header = this._innerContentElement.createChild("h1");
- header.textContent = WebInspector.UIString("Select profiling type");
+ var header = this._innerContentElement.createChild('h1');
+ header.textContent = WebInspector.UIString('Select profiling type');
- this._profileTypeSelectorForm = this._innerContentElement.createChild("form");
+ this._profileTypeSelectorForm = this._innerContentElement.createChild('form');
- this._innerContentElement.createChild("div", "flexible-space");
+ this._innerContentElement.createChild('div', 'flexible-space');
this._typeIdToOptionElement = {};
+ }
+
+ /**
+ * @override
+ * @param {!WebInspector.ProfileType} profileType
+ */
+ addProfileType(profileType) {
+ var labelElement = createRadioLabel('profile-type', profileType.name);
+ this._profileTypeSelectorForm.appendChild(labelElement);
+ var optionElement = labelElement.radioElement;
+ this._typeIdToOptionElement[profileType.id] = optionElement;
+ optionElement._profileType = profileType;
+ optionElement.style.hidden = true;
+ optionElement.addEventListener('change', this._profileTypeChanged.bind(this, profileType), false);
+ var descriptionElement = labelElement.createChild('p');
+ descriptionElement.textContent = profileType.description;
+ var decorationElement = profileType.decorationElement();
+ if (decorationElement)
+ labelElement.appendChild(decorationElement);
+ }
+
+ restoreSelectedProfileType() {
+ var typeId = this._selectedProfileTypeSetting.get();
+ if (!(typeId in this._typeIdToOptionElement))
+ typeId = Object.keys(this._typeIdToOptionElement)[0];
+ this._typeIdToOptionElement[typeId].checked = true;
+ var type = this._typeIdToOptionElement[typeId]._profileType;
+ this.dispatchEventToListeners(WebInspector.MultiProfileLauncherView.Events.ProfileTypeSelected, type);
+ }
+
+ /**
+ * @override
+ */
+ _controlButtonClicked() {
+ this._panel.toggleRecord();
+ }
+
+ /**
+ * @override
+ */
+ _updateControls() {
+ super._updateControls();
+ var items = this._profileTypeSelectorForm.elements;
+ for (var i = 0; i < items.length; ++i) {
+ if (items[i].type === 'radio')
+ items[i].disabled = this._isProfiling;
+ }
+ }
+
+ /**
+ * @param {!WebInspector.ProfileType} profileType
+ */
+ _profileTypeChanged(profileType) {
+ this.dispatchEventToListeners(WebInspector.MultiProfileLauncherView.Events.ProfileTypeSelected, profileType);
+ this._isInstantProfile = profileType.isInstantProfile();
+ this._isEnabled = profileType.isEnabled();
+ this._updateControls();
+ this._selectedProfileTypeSetting.set(profileType.id);
+ }
+
+ /**
+ * @override
+ */
+ profileStarted() {
+ this._isProfiling = true;
+ this._updateControls();
+ }
+
+ /**
+ * @override
+ */
+ profileFinished() {
+ this._isProfiling = false;
+ this._updateControls();
+ }
};
/** @enum {symbol} */
WebInspector.MultiProfileLauncherView.Events = {
- ProfileTypeSelected: Symbol("ProfileTypeSelected")
-};
-
-WebInspector.MultiProfileLauncherView.prototype = {
- /**
- * @override
- * @param {!WebInspector.ProfileType} profileType
- */
- addProfileType: function(profileType)
- {
- var labelElement = createRadioLabel("profile-type", profileType.name);
- this._profileTypeSelectorForm.appendChild(labelElement);
- var optionElement = labelElement.radioElement;
- this._typeIdToOptionElement[profileType.id] = optionElement;
- optionElement._profileType = profileType;
- optionElement.style.hidden = true;
- optionElement.addEventListener("change", this._profileTypeChanged.bind(this, profileType), false);
- var descriptionElement = labelElement.createChild("p");
- descriptionElement.textContent = profileType.description;
- var decorationElement = profileType.decorationElement();
- if (decorationElement)
- labelElement.appendChild(decorationElement);
- },
-
- restoreSelectedProfileType: function()
- {
- var typeId = this._selectedProfileTypeSetting.get();
- if (!(typeId in this._typeIdToOptionElement))
- typeId = Object.keys(this._typeIdToOptionElement)[0];
- this._typeIdToOptionElement[typeId].checked = true;
- var type = this._typeIdToOptionElement[typeId]._profileType;
- this.dispatchEventToListeners(WebInspector.MultiProfileLauncherView.Events.ProfileTypeSelected, type);
- },
-
- _controlButtonClicked: function()
- {
- this._panel.toggleRecord();
- },
-
- _updateControls: function()
- {
- WebInspector.ProfileLauncherView.prototype._updateControls.call(this);
- var items = this._profileTypeSelectorForm.elements;
- for (var i = 0; i < items.length; ++i) {
- if (items[i].type === "radio")
- items[i].disabled = this._isProfiling;
- }
- },
-
- /**
- * @param {!WebInspector.ProfileType} profileType
- */
- _profileTypeChanged: function(profileType)
- {
- this.dispatchEventToListeners(WebInspector.MultiProfileLauncherView.Events.ProfileTypeSelected, profileType);
- this._isInstantProfile = profileType.isInstantProfile();
- this._isEnabled = profileType.isEnabled();
- this._updateControls();
- this._selectedProfileTypeSetting.set(profileType.id);
- },
-
- profileStarted: function()
- {
- this._isProfiling = true;
- this._updateControls();
- },
-
- profileFinished: function()
- {
- this._isProfiling = false;
- this._updateControls();
- },
-
- __proto__: WebInspector.ProfileLauncherView.prototype
+ ProfileTypeSelected: Symbol('ProfileTypeSelected')
};

Powered by Google App Engine
This is Rietveld 408576698