Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SimpleHistoryManager.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SimpleHistoryManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SimpleHistoryManager.js b/third_party/WebKit/Source/devtools/front_end/sources/SimpleHistoryManager.js
index 63b80a1032f8f8243dea2ca4efb3aece6f7a4a25..3d7379c7e306712dfc1b58f748a1409feccff6e3 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SimpleHistoryManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SimpleHistoryManager.js
@@ -27,141 +27,132 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-
/**
* @interface
*/
-WebInspector.HistoryEntry = function() { };
+WebInspector.HistoryEntry = function() {};
WebInspector.HistoryEntry.prototype = {
- /**
- * @return {boolean}
- */
- valid: function() { },
+ /**
+ * @return {boolean}
+ */
+ valid: function() {},
- reveal: function() { }
+ reveal: function() {}
};
/**
- * @constructor
- * @param {number} historyDepth
+ * @unrestricted
*/
-WebInspector.SimpleHistoryManager = function(historyDepth)
-{
+WebInspector.SimpleHistoryManager = class {
+ /**
+ * @param {number} historyDepth
+ */
+ constructor(historyDepth) {
this._entries = [];
this._activeEntryIndex = -1;
this._coalescingReadonly = 0;
this._historyDepth = historyDepth;
-};
-
-WebInspector.SimpleHistoryManager.prototype = {
- readOnlyLock: function()
- {
- ++this._coalescingReadonly;
- },
-
- releaseReadOnlyLock: function()
- {
- --this._coalescingReadonly;
- },
-
- /**
- * @return {boolean}
- */
- readOnly: function()
- {
- return !!this._coalescingReadonly;
- },
-
- /**
- * @param {function(!WebInspector.HistoryEntry):boolean} filterOutCallback
- */
- filterOut: function(filterOutCallback)
- {
- if (this.readOnly())
- return;
- var filteredEntries = [];
- var removedBeforeActiveEntry = 0;
- for (var i = 0; i < this._entries.length; ++i) {
- if (!filterOutCallback(this._entries[i])) {
- filteredEntries.push(this._entries[i]);
- } else if (i <= this._activeEntryIndex)
- ++removedBeforeActiveEntry;
- }
- this._entries = filteredEntries;
- this._activeEntryIndex = Math.max(0, this._activeEntryIndex - removedBeforeActiveEntry);
- },
-
- /**
- * @return {boolean}
- */
- empty: function()
- {
- return !this._entries.length;
- },
-
- /**
- * @return {?WebInspector.HistoryEntry}
- */
- active: function()
- {
- return this.empty() ? null : this._entries[this._activeEntryIndex];
- },
-
- /**
- * @param {!WebInspector.HistoryEntry} entry
- */
- push: function(entry)
- {
- if (this.readOnly())
- return;
- if (!this.empty())
- this._entries.splice(this._activeEntryIndex + 1);
- this._entries.push(entry);
- if (this._entries.length > this._historyDepth)
- this._entries.shift();
- this._activeEntryIndex = this._entries.length - 1;
- },
-
- /**
- * @return {boolean}
- */
- rollback: function()
- {
- if (this.empty())
- return false;
-
- var revealIndex = this._activeEntryIndex - 1;
- while (revealIndex >= 0 && !this._entries[revealIndex].valid())
- --revealIndex;
- if (revealIndex < 0)
- return false;
-
- this.readOnlyLock();
- this._entries[revealIndex].reveal();
- this.releaseReadOnlyLock();
-
- this._activeEntryIndex = revealIndex;
- return true;
- },
-
- /**
- * @return {boolean}
- */
- rollover: function()
- {
- var revealIndex = this._activeEntryIndex + 1;
-
- while (revealIndex < this._entries.length && !this._entries[revealIndex].valid())
- ++revealIndex;
- if (revealIndex >= this._entries.length)
- return false;
-
- this.readOnlyLock();
- this._entries[revealIndex].reveal();
- this.releaseReadOnlyLock();
-
- this._activeEntryIndex = revealIndex;
- return true;
- },
+ }
+
+ readOnlyLock() {
+ ++this._coalescingReadonly;
+ }
+
+ releaseReadOnlyLock() {
+ --this._coalescingReadonly;
+ }
+
+ /**
+ * @return {boolean}
+ */
+ readOnly() {
+ return !!this._coalescingReadonly;
+ }
+
+ /**
+ * @param {function(!WebInspector.HistoryEntry):boolean} filterOutCallback
+ */
+ filterOut(filterOutCallback) {
+ if (this.readOnly())
+ return;
+ var filteredEntries = [];
+ var removedBeforeActiveEntry = 0;
+ for (var i = 0; i < this._entries.length; ++i) {
+ if (!filterOutCallback(this._entries[i])) {
+ filteredEntries.push(this._entries[i]);
+ } else if (i <= this._activeEntryIndex)
+ ++removedBeforeActiveEntry;
+ }
+ this._entries = filteredEntries;
+ this._activeEntryIndex = Math.max(0, this._activeEntryIndex - removedBeforeActiveEntry);
+ }
+
+ /**
+ * @return {boolean}
+ */
+ empty() {
+ return !this._entries.length;
+ }
+
+ /**
+ * @return {?WebInspector.HistoryEntry}
+ */
+ active() {
+ return this.empty() ? null : this._entries[this._activeEntryIndex];
+ }
+
+ /**
+ * @param {!WebInspector.HistoryEntry} entry
+ */
+ push(entry) {
+ if (this.readOnly())
+ return;
+ if (!this.empty())
+ this._entries.splice(this._activeEntryIndex + 1);
+ this._entries.push(entry);
+ if (this._entries.length > this._historyDepth)
+ this._entries.shift();
+ this._activeEntryIndex = this._entries.length - 1;
+ }
+
+ /**
+ * @return {boolean}
+ */
+ rollback() {
+ if (this.empty())
+ return false;
+
+ var revealIndex = this._activeEntryIndex - 1;
+ while (revealIndex >= 0 && !this._entries[revealIndex].valid())
+ --revealIndex;
+ if (revealIndex < 0)
+ return false;
+
+ this.readOnlyLock();
+ this._entries[revealIndex].reveal();
+ this.releaseReadOnlyLock();
+
+ this._activeEntryIndex = revealIndex;
+ return true;
+ }
+
+ /**
+ * @return {boolean}
+ */
+ rollover() {
+ var revealIndex = this._activeEntryIndex + 1;
+
+ while (revealIndex < this._entries.length && !this._entries[revealIndex].valid())
+ ++revealIndex;
+ if (revealIndex >= this._entries.length)
+ return false;
+
+ this.readOnlyLock();
+ this._entries[revealIndex].reveal();
+ this.releaseReadOnlyLock();
+
+ this._activeEntryIndex = revealIndex;
+ return true;
+ }
};

Powered by Google App Engine
This is Rietveld 408576698