Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: third_party/WebKit/Source/devtools/front_end/layer_viewer/LayerViewHost.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/layer_viewer/LayerViewHost.js
diff --git a/third_party/WebKit/Source/devtools/front_end/layer_viewer/LayerViewHost.js b/third_party/WebKit/Source/devtools/front_end/layer_viewer/LayerViewHost.js
index a4d6f720150585224b4a68e0ef180705f02162d9..2f63e60deba83e317111dbb0a4cb9e62850bf32c 100644
--- a/third_party/WebKit/Source/devtools/front_end/layer_viewer/LayerViewHost.js
+++ b/third_party/WebKit/Source/devtools/front_end/layer_viewer/LayerViewHost.js
@@ -3,283 +3,258 @@
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
-
/**
* @interface
*/
-WebInspector.LayerView = function()
-{
-};
+WebInspector.LayerView = function() {};
WebInspector.LayerView.prototype = {
- /**
- * @param {?WebInspector.LayerView.Selection} selection
- */
- hoverObject: function(selection) { },
-
- /**
- * @param {?WebInspector.LayerView.Selection} selection
- */
- selectObject: function(selection) { },
-
- /**
- * @param {?WebInspector.LayerTreeBase} layerTree
- */
- setLayerTree: function(layerTree) { }
+ /**
+ * @param {?WebInspector.LayerView.Selection} selection
+ */
+ hoverObject: function(selection) {},
+
+ /**
+ * @param {?WebInspector.LayerView.Selection} selection
+ */
+ selectObject: function(selection) {},
+
+ /**
+ * @param {?WebInspector.LayerTreeBase} layerTree
+ */
+ setLayerTree: function(layerTree) {}
};
-
/**
- * @constructor
- * @param {!WebInspector.LayerView.Selection.Type} type
- * @param {!WebInspector.Layer} layer
+ * @unrestricted
*/
-WebInspector.LayerView.Selection = function(type, layer)
-{
+WebInspector.LayerView.Selection = class {
+ /**
+ * @param {!WebInspector.LayerView.Selection.Type} type
+ * @param {!WebInspector.Layer} layer
+ */
+ constructor(type, layer) {
this._type = type;
this._layer = layer;
+ }
+
+ /**
+ * @param {?WebInspector.LayerView.Selection} a
+ * @param {?WebInspector.LayerView.Selection} b
+ * @return {boolean}
+ */
+ static isEqual(a, b) {
+ return a && b ? a._isEqual(b) : a === b;
+ }
+
+ /**
+ * @return {!WebInspector.LayerView.Selection.Type}
+ */
+ type() {
+ return this._type;
+ }
+
+ /**
+ * @return {!WebInspector.Layer}
+ */
+ layer() {
+ return this._layer;
+ }
+
+ /**
+ * @param {!WebInspector.LayerView.Selection} other
+ * @return {boolean}
+ */
+ _isEqual(other) {
+ return false;
+ }
};
/**
* @enum {symbol}
*/
WebInspector.LayerView.Selection.Type = {
- Layer: Symbol("Layer"),
- ScrollRect: Symbol("ScrollRect"),
- Snapshot: Symbol("Snapshot")
-};
-
-/**
- * @param {?WebInspector.LayerView.Selection} a
- * @param {?WebInspector.LayerView.Selection} b
- * @return {boolean}
- */
-WebInspector.LayerView.Selection.isEqual = function(a, b)
-{
- return a && b ? a._isEqual(b) : a === b;
+ Layer: Symbol('Layer'),
+ ScrollRect: Symbol('ScrollRect'),
+ Snapshot: Symbol('Snapshot')
};
-WebInspector.LayerView.Selection.prototype = {
- /**
- * @return {!WebInspector.LayerView.Selection.Type}
- */
- type: function()
- {
- return this._type;
- },
-
- /**
- * @return {!WebInspector.Layer}
- */
- layer: function()
- {
- return this._layer;
- },
-
- /**
- * @param {!WebInspector.LayerView.Selection} other
- * @return {boolean}
- */
- _isEqual: function(other)
- {
- return false;
- }
-};
/**
- * @constructor
- * @extends {WebInspector.LayerView.Selection}
- * @param {!WebInspector.Layer} layer
+ * @unrestricted
*/
-WebInspector.LayerView.LayerSelection = function(layer)
-{
- console.assert(layer, "LayerSelection with empty layer");
- WebInspector.LayerView.Selection.call(this, WebInspector.LayerView.Selection.Type.Layer, layer);
-};
-
-WebInspector.LayerView.LayerSelection.prototype = {
- /**
- * @override
- * @param {!WebInspector.LayerView.Selection} other
- * @return {boolean}
- */
- _isEqual: function(other)
- {
- return other._type === WebInspector.LayerView.Selection.Type.Layer && other.layer().id() === this.layer().id();
- },
-
- __proto__: WebInspector.LayerView.Selection.prototype
+WebInspector.LayerView.LayerSelection = class extends WebInspector.LayerView.Selection {
+ /**
+ * @param {!WebInspector.Layer} layer
+ */
+ constructor(layer) {
+ console.assert(layer, 'LayerSelection with empty layer');
+ super(WebInspector.LayerView.Selection.Type.Layer, layer);
+ }
+
+ /**
+ * @override
+ * @param {!WebInspector.LayerView.Selection} other
+ * @return {boolean}
+ */
+ _isEqual(other) {
+ return other._type === WebInspector.LayerView.Selection.Type.Layer && other.layer().id() === this.layer().id();
+ }
};
/**
- * @constructor
- * @extends {WebInspector.LayerView.Selection}
- * @param {!WebInspector.Layer} layer
- * @param {number} scrollRectIndex
+ * @unrestricted
*/
-WebInspector.LayerView.ScrollRectSelection = function(layer, scrollRectIndex)
-{
- WebInspector.LayerView.Selection.call(this, WebInspector.LayerView.Selection.Type.ScrollRect, layer);
+WebInspector.LayerView.ScrollRectSelection = class extends WebInspector.LayerView.Selection {
+ /**
+ * @param {!WebInspector.Layer} layer
+ * @param {number} scrollRectIndex
+ */
+ constructor(layer, scrollRectIndex) {
+ super(WebInspector.LayerView.Selection.Type.ScrollRect, layer);
this.scrollRectIndex = scrollRectIndex;
-};
-
-WebInspector.LayerView.ScrollRectSelection.prototype = {
- /**
- * @override
- * @param {!WebInspector.LayerView.Selection} other
- * @return {boolean}
- */
- _isEqual: function(other)
- {
- return other._type === WebInspector.LayerView.Selection.Type.ScrollRect &&
- this.layer().id() === other.layer().id() && this.scrollRectIndex === other.scrollRectIndex;
- },
-
- __proto__: WebInspector.LayerView.Selection.prototype
+ }
+
+ /**
+ * @override
+ * @param {!WebInspector.LayerView.Selection} other
+ * @return {boolean}
+ */
+ _isEqual(other) {
+ return other._type === WebInspector.LayerView.Selection.Type.ScrollRect &&
+ this.layer().id() === other.layer().id() && this.scrollRectIndex === other.scrollRectIndex;
+ }
};
/**
- * @constructor
- * @extends {WebInspector.LayerView.Selection}
- * @param {!WebInspector.Layer} layer
- * @param {!WebInspector.SnapshotWithRect} snapshot
+ * @unrestricted
*/
-WebInspector.LayerView.SnapshotSelection = function(layer, snapshot)
-{
- WebInspector.LayerView.Selection.call(this, WebInspector.LayerView.Selection.Type.Snapshot, layer);
+WebInspector.LayerView.SnapshotSelection = class extends WebInspector.LayerView.Selection {
+ /**
+ * @param {!WebInspector.Layer} layer
+ * @param {!WebInspector.SnapshotWithRect} snapshot
+ */
+ constructor(layer, snapshot) {
+ super(WebInspector.LayerView.Selection.Type.Snapshot, layer);
this._snapshot = snapshot;
-};
-
-WebInspector.LayerView.SnapshotSelection.prototype = {
- /**
- * @override
- * @param {!WebInspector.LayerView.Selection} other
- * @return {boolean}
- */
- _isEqual: function(other)
- {
- return other._type === WebInspector.LayerView.Selection.Type.Snapshot
- && this.layer().id() === other.layer().id() && this._snapshot === other._snapshot;
- },
-
- /**
- * @return {!WebInspector.SnapshotWithRect}
- */
- snapshot: function()
- {
- return this._snapshot;
- },
-
- __proto__: WebInspector.LayerView.Selection.prototype
+ }
+
+ /**
+ * @override
+ * @param {!WebInspector.LayerView.Selection} other
+ * @return {boolean}
+ */
+ _isEqual(other) {
+ return other._type === WebInspector.LayerView.Selection.Type.Snapshot && this.layer().id() === other.layer().id() &&
+ this._snapshot === other._snapshot;
+ }
+
+ /**
+ * @return {!WebInspector.SnapshotWithRect}
+ */
+ snapshot() {
+ return this._snapshot;
+ }
};
/**
- * @constructor
+ * @unrestricted
*/
-WebInspector.LayerViewHost = function()
-{
+WebInspector.LayerViewHost = class {
+ constructor() {
/** @type {!Array.<!WebInspector.LayerView>} */
this._views = [];
this._selectedObject = null;
this._hoveredObject = null;
- this._showInternalLayersSetting = WebInspector.settings.createSetting("layersShowInternalLayers", false);
-};
-
-WebInspector.LayerViewHost.prototype = {
- /**
- * @param {!WebInspector.LayerView} layerView
- */
- registerView: function(layerView)
- {
- this._views.push(layerView);
- },
-
- /**
- * @param {?WebInspector.LayerTreeBase} layerTree
- */
- setLayerTree: function(layerTree)
- {
- this._target = layerTree.target();
- var selectedLayer = this._selectedObject && this._selectedObject.layer();
- if (selectedLayer && (!layerTree || !layerTree.layerById(selectedLayer.id())))
- this.selectObject(null);
- var hoveredLayer = this._hoveredObject && this._hoveredObject.layer();
- if (hoveredLayer && (!layerTree || !layerTree.layerById(hoveredLayer.id())))
- this.hoverObject(null);
- for (var view of this._views)
- view.setLayerTree(layerTree);
- },
-
- /**
- * @param {?WebInspector.LayerView.Selection} selection
- */
- hoverObject: function(selection)
- {
- if (WebInspector.LayerView.Selection.isEqual(this._hoveredObject, selection))
- return;
- this._hoveredObject = selection;
- var layer = selection && selection.layer();
- this._toggleNodeHighlight(layer ? layer.nodeForSelfOrAncestor() : null);
- for (var view of this._views)
- view.hoverObject(selection);
- },
-
- /**
- * @param {?WebInspector.LayerView.Selection} selection
- */
- selectObject: function(selection)
- {
- if (WebInspector.LayerView.Selection.isEqual(this._selectedObject, selection))
- return;
- this._selectedObject = selection;
- for (var view of this._views)
- view.selectObject(selection);
- },
-
- /**
- * @return {?WebInspector.LayerView.Selection}
- */
- selection: function()
- {
- return this._selectedObject;
- },
-
- /**
- * @param {!WebInspector.ContextMenu} contextMenu
- * @param {?WebInspector.LayerView.Selection} selection
- */
- showContextMenu: function(contextMenu, selection)
- {
- contextMenu.appendCheckboxItem(WebInspector.UIString("Show internal layers"), this._toggleShowInternalLayers.bind(this), this._showInternalLayersSetting.get());
- var node = selection && selection.layer() && selection.layer().nodeForSelfOrAncestor();
- if (node)
- contextMenu.appendApplicableItems(node);
- contextMenu.show();
- },
-
- /**
- * @return {!WebInspector.Setting}
- */
- showInternalLayersSetting: function()
- {
- return this._showInternalLayersSetting;
- },
-
- _toggleShowInternalLayers: function()
- {
- this._showInternalLayersSetting.set(!this._showInternalLayersSetting.get());
- },
-
- /**
- * @param {?WebInspector.DOMNode} node
- */
- _toggleNodeHighlight: function(node)
- {
- if (node) {
- node.highlightForTwoSeconds();
- return;
- }
- WebInspector.DOMModel.hideDOMNodeHighlight();
+ this._showInternalLayersSetting = WebInspector.settings.createSetting('layersShowInternalLayers', false);
+ }
+
+ /**
+ * @param {!WebInspector.LayerView} layerView
+ */
+ registerView(layerView) {
+ this._views.push(layerView);
+ }
+
+ /**
+ * @param {?WebInspector.LayerTreeBase} layerTree
+ */
+ setLayerTree(layerTree) {
+ this._target = layerTree.target();
+ var selectedLayer = this._selectedObject && this._selectedObject.layer();
+ if (selectedLayer && (!layerTree || !layerTree.layerById(selectedLayer.id())))
+ this.selectObject(null);
+ var hoveredLayer = this._hoveredObject && this._hoveredObject.layer();
+ if (hoveredLayer && (!layerTree || !layerTree.layerById(hoveredLayer.id())))
+ this.hoverObject(null);
+ for (var view of this._views)
+ view.setLayerTree(layerTree);
+ }
+
+ /**
+ * @param {?WebInspector.LayerView.Selection} selection
+ */
+ hoverObject(selection) {
+ if (WebInspector.LayerView.Selection.isEqual(this._hoveredObject, selection))
+ return;
+ this._hoveredObject = selection;
+ var layer = selection && selection.layer();
+ this._toggleNodeHighlight(layer ? layer.nodeForSelfOrAncestor() : null);
+ for (var view of this._views)
+ view.hoverObject(selection);
+ }
+
+ /**
+ * @param {?WebInspector.LayerView.Selection} selection
+ */
+ selectObject(selection) {
+ if (WebInspector.LayerView.Selection.isEqual(this._selectedObject, selection))
+ return;
+ this._selectedObject = selection;
+ for (var view of this._views)
+ view.selectObject(selection);
+ }
+
+ /**
+ * @return {?WebInspector.LayerView.Selection}
+ */
+ selection() {
+ return this._selectedObject;
+ }
+
+ /**
+ * @param {!WebInspector.ContextMenu} contextMenu
+ * @param {?WebInspector.LayerView.Selection} selection
+ */
+ showContextMenu(contextMenu, selection) {
+ contextMenu.appendCheckboxItem(
+ WebInspector.UIString('Show internal layers'), this._toggleShowInternalLayers.bind(this),
+ this._showInternalLayersSetting.get());
+ var node = selection && selection.layer() && selection.layer().nodeForSelfOrAncestor();
+ if (node)
+ contextMenu.appendApplicableItems(node);
+ contextMenu.show();
+ }
+
+ /**
+ * @return {!WebInspector.Setting}
+ */
+ showInternalLayersSetting() {
+ return this._showInternalLayersSetting;
+ }
+
+ _toggleShowInternalLayers() {
+ this._showInternalLayersSetting.set(!this._showInternalLayersSetting.get());
+ }
+
+ /**
+ * @param {?WebInspector.DOMNode} node
+ */
+ _toggleNodeHighlight(node) {
+ if (node) {
+ node.highlightForTwoSeconds();
+ return;
}
+ WebInspector.DOMModel.hideDOMNodeHighlight();
+ }
};
-

Powered by Google App Engine
This is Rietveld 408576698