Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
index 695e39d7a7c7831c58d435a647a0f1060a25f64c..524369fecdfc48cb3ea5fa98b68038c90d853fd7 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
@@ -1,298 +1,275 @@
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
/**
- * @constructor
- * @param {!WebInspector.Target} target
- * @param {!WebInspector.TimelineLifecycleDelegate} delegate
- * @param {!WebInspector.TracingModel} tracingModel
* @implements {WebInspector.TargetManager.Observer}
* @implements {WebInspector.TracingManagerClient}
+ * @unrestricted
*/
-WebInspector.TimelineController = function(target, delegate, tracingModel)
-{
+WebInspector.TimelineController = class {
+ /**
+ * @param {!WebInspector.Target} target
+ * @param {!WebInspector.TimelineLifecycleDelegate} delegate
+ * @param {!WebInspector.TracingModel} tracingModel
+ */
+ constructor(target, delegate, tracingModel) {
this._delegate = delegate;
this._target = target;
this._tracingModel = tracingModel;
this._targets = [];
WebInspector.targetManager.observeTargets(this);
-};
+ }
-WebInspector.TimelineController.prototype = {
- /**
- * @param {boolean} captureCauses
- * @param {boolean} enableJSSampling
- * @param {boolean} captureMemory
- * @param {boolean} capturePictures
- * @param {boolean} captureFilmStrip
- */
- startRecording: function(captureCauses, enableJSSampling, captureMemory, capturePictures, captureFilmStrip)
- {
- this._extensionTraceProviders = WebInspector.extensionServer.traceProviders().slice();
+ /**
+ * @param {boolean} captureCauses
+ * @param {boolean} enableJSSampling
+ * @param {boolean} captureMemory
+ * @param {boolean} capturePictures
+ * @param {boolean} captureFilmStrip
+ */
+ startRecording(captureCauses, enableJSSampling, captureMemory, capturePictures, captureFilmStrip) {
+ this._extensionTraceProviders = WebInspector.extensionServer.traceProviders().slice();
- function disabledByDefault(category)
- {
- return "disabled-by-default-" + category;
- }
- var categoriesArray = [
- "-*",
- "devtools.timeline",
- "v8.execute",
- disabledByDefault("devtools.timeline"),
- disabledByDefault("devtools.timeline.frame"),
- WebInspector.TracingModel.TopLevelEventCategory,
- WebInspector.TimelineModel.Category.Console,
- WebInspector.TimelineModel.Category.UserTiming
- ];
- categoriesArray.push(WebInspector.TimelineModel.Category.LatencyInfo);
+ function disabledByDefault(category) {
+ return 'disabled-by-default-' + category;
+ }
+ var categoriesArray = [
+ '-*', 'devtools.timeline', 'v8.execute', disabledByDefault('devtools.timeline'),
+ disabledByDefault('devtools.timeline.frame'), WebInspector.TracingModel.TopLevelEventCategory,
+ WebInspector.TimelineModel.Category.Console, WebInspector.TimelineModel.Category.UserTiming
+ ];
+ categoriesArray.push(WebInspector.TimelineModel.Category.LatencyInfo);
- if (Runtime.experiments.isEnabled("timelineFlowEvents")) {
- categoriesArray.push(disabledByDefault("toplevel.flow"),
- disabledByDefault("ipc.flow"));
- }
- if (Runtime.experiments.isEnabled("timelineV8RuntimeCallStats") && enableJSSampling)
- categoriesArray.push(disabledByDefault("v8.runtime_stats"));
- if (Runtime.experiments.isEnabled("timelineTracingJSProfile") && enableJSSampling) {
- categoriesArray.push(disabledByDefault("v8.cpu_profiler"));
- if (WebInspector.moduleSetting("highResolutionCpuProfiling").get())
- categoriesArray.push(disabledByDefault("v8.cpu_profiler.hires"));
- }
- if (captureCauses || enableJSSampling)
- categoriesArray.push(disabledByDefault("devtools.timeline.stack"));
- if (captureCauses && Runtime.experiments.isEnabled("timelineInvalidationTracking"))
- categoriesArray.push(disabledByDefault("devtools.timeline.invalidationTracking"));
- if (capturePictures) {
- categoriesArray.push(disabledByDefault("devtools.timeline.layers"),
- disabledByDefault("devtools.timeline.picture"),
- disabledByDefault("blink.graphics_context_annotations"));
- }
- if (captureFilmStrip)
- categoriesArray.push(disabledByDefault("devtools.screenshot"));
+ if (Runtime.experiments.isEnabled('timelineFlowEvents')) {
+ categoriesArray.push(disabledByDefault('toplevel.flow'), disabledByDefault('ipc.flow'));
+ }
+ if (Runtime.experiments.isEnabled('timelineV8RuntimeCallStats') && enableJSSampling)
+ categoriesArray.push(disabledByDefault('v8.runtime_stats'));
+ if (Runtime.experiments.isEnabled('timelineTracingJSProfile') && enableJSSampling) {
+ categoriesArray.push(disabledByDefault('v8.cpu_profiler'));
+ if (WebInspector.moduleSetting('highResolutionCpuProfiling').get())
+ categoriesArray.push(disabledByDefault('v8.cpu_profiler.hires'));
+ }
+ if (captureCauses || enableJSSampling)
+ categoriesArray.push(disabledByDefault('devtools.timeline.stack'));
+ if (captureCauses && Runtime.experiments.isEnabled('timelineInvalidationTracking'))
+ categoriesArray.push(disabledByDefault('devtools.timeline.invalidationTracking'));
+ if (capturePictures) {
+ categoriesArray.push(
+ disabledByDefault('devtools.timeline.layers'), disabledByDefault('devtools.timeline.picture'),
+ disabledByDefault('blink.graphics_context_annotations'));
+ }
+ if (captureFilmStrip)
+ categoriesArray.push(disabledByDefault('devtools.screenshot'));
- for (var traceProvider of this._extensionTraceProviders)
- traceProvider.start();
+ for (var traceProvider of this._extensionTraceProviders)
+ traceProvider.start();
- var categories = categoriesArray.join(",");
- this._startRecordingWithCategories(categories, enableJSSampling);
- },
+ var categories = categoriesArray.join(',');
+ this._startRecordingWithCategories(categories, enableJSSampling);
+ }
- stopRecording: function()
- {
- var tracingStoppedPromises = [];
- tracingStoppedPromises.push(new Promise(resolve => this._tracingCompleteCallback = resolve));
- tracingStoppedPromises.push(this._stopProfilingOnAllTargets());
- this._target.tracingManager.stop();
- tracingStoppedPromises.push(WebInspector.targetManager.resumeAllTargets());
- Promise.all(tracingStoppedPromises).then(() => this._allSourcesFinished());
+ stopRecording() {
+ var tracingStoppedPromises = [];
+ tracingStoppedPromises.push(new Promise(resolve => this._tracingCompleteCallback = resolve));
+ tracingStoppedPromises.push(this._stopProfilingOnAllTargets());
+ this._target.tracingManager.stop();
+ tracingStoppedPromises.push(WebInspector.targetManager.resumeAllTargets());
+ Promise.all(tracingStoppedPromises).then(() => this._allSourcesFinished());
- this._delegate.loadingStarted();
+ this._delegate.loadingStarted();
- for (var traceProvider of this._extensionTraceProviders)
- traceProvider.stop();
- },
+ for (var traceProvider of this._extensionTraceProviders)
+ traceProvider.stop();
+ }
- /**
- * @override
- * @param {!WebInspector.Target} target
- */
- targetAdded: function(target)
- {
- this._targets.push(target);
- if (this._profiling)
- this._startProfilingOnTarget(target);
- },
+ /**
+ * @override
+ * @param {!WebInspector.Target} target
+ */
+ targetAdded(target) {
+ this._targets.push(target);
+ if (this._profiling)
+ this._startProfilingOnTarget(target);
+ }
- /**
- * @override
- * @param {!WebInspector.Target} target
- */
- targetRemoved: function(target)
- {
- this._targets.remove(target, true);
- // FIXME: We'd like to stop profiling on the target and retrieve a profile
- // but it's too late. Backend connection is closed.
- },
+ /**
+ * @override
+ * @param {!WebInspector.Target} target
+ */
+ targetRemoved(target) {
+ this._targets.remove(target, true);
+ // FIXME: We'd like to stop profiling on the target and retrieve a profile
+ // but it's too late. Backend connection is closed.
+ }
- /**
- * @param {!WebInspector.Target} target
- * @return {!Promise}
- */
- _startProfilingOnTarget: function(target)
- {
- return target.hasJSCapability() ? target.profilerAgent().start() : Promise.resolve();
- },
+ /**
+ * @param {!WebInspector.Target} target
+ * @return {!Promise}
+ */
+ _startProfilingOnTarget(target) {
+ return target.hasJSCapability() ? target.profilerAgent().start() : Promise.resolve();
+ }
- /**
- * @return {!Promise}
- */
- _startProfilingOnAllTargets: function()
- {
- var intervalUs = WebInspector.moduleSetting("highResolutionCpuProfiling").get() ? 100 : 1000;
- this._target.profilerAgent().setSamplingInterval(intervalUs);
- this._profiling = true;
- return Promise.all(this._targets.map(this._startProfilingOnTarget));
- },
+ /**
+ * @return {!Promise}
+ */
+ _startProfilingOnAllTargets() {
+ var intervalUs = WebInspector.moduleSetting('highResolutionCpuProfiling').get() ? 100 : 1000;
+ this._target.profilerAgent().setSamplingInterval(intervalUs);
+ this._profiling = true;
+ return Promise.all(this._targets.map(this._startProfilingOnTarget));
+ }
- /**
- * @param {!WebInspector.Target} target
- * @return {!Promise}
- */
- _stopProfilingOnTarget: function(target)
- {
- return target.hasJSCapability() ? target.profilerAgent().stop(this._addCpuProfile.bind(this, target.id())) : Promise.resolve();
- },
+ /**
+ * @param {!WebInspector.Target} target
+ * @return {!Promise}
+ */
+ _stopProfilingOnTarget(target) {
+ return target.hasJSCapability() ? target.profilerAgent().stop(this._addCpuProfile.bind(this, target.id())) :
+ Promise.resolve();
+ }
- /**
- * @param {number} targetId
- * @param {?Protocol.Error} error
- * @param {?ProfilerAgent.Profile} cpuProfile
- */
- _addCpuProfile: function(targetId, error, cpuProfile)
- {
- if (!cpuProfile) {
- WebInspector.console.warn(WebInspector.UIString("CPU profile for a target is not available. %s", error || ""));
- return;
- }
- if (!this._cpuProfiles)
- this._cpuProfiles = new Map();
- this._cpuProfiles.set(targetId, cpuProfile);
- },
+ /**
+ * @param {number} targetId
+ * @param {?Protocol.Error} error
+ * @param {?ProfilerAgent.Profile} cpuProfile
+ */
+ _addCpuProfile(targetId, error, cpuProfile) {
+ if (!cpuProfile) {
+ WebInspector.console.warn(WebInspector.UIString('CPU profile for a target is not available. %s', error || ''));
+ return;
+ }
+ if (!this._cpuProfiles)
+ this._cpuProfiles = new Map();
+ this._cpuProfiles.set(targetId, cpuProfile);
+ }
- /**
- * @return {!Promise}
- */
- _stopProfilingOnAllTargets: function()
- {
- var targets = this._profiling ? this._targets : [];
- this._profiling = false;
- return Promise.all(targets.map(this._stopProfilingOnTarget, this));
- },
+ /**
+ * @return {!Promise}
+ */
+ _stopProfilingOnAllTargets() {
+ var targets = this._profiling ? this._targets : [];
+ this._profiling = false;
+ return Promise.all(targets.map(this._stopProfilingOnTarget, this));
+ }
+ /**
+ * @param {string} categories
+ * @param {boolean=} enableJSSampling
+ * @param {function(?string)=} callback
+ */
+ _startRecordingWithCategories(categories, enableJSSampling, callback) {
+ WebInspector.targetManager.suspendAllTargets();
+ var profilingStartedPromise = enableJSSampling && !Runtime.experiments.isEnabled('timelineTracingJSProfile') ?
+ this._startProfilingOnAllTargets() :
+ Promise.resolve();
+ var samplingFrequencyHz = WebInspector.moduleSetting('highResolutionCpuProfiling').get() ? 10000 : 1000;
+ var options = 'sampling-frequency=' + samplingFrequencyHz;
+ var target = this._target;
+ var tracingManager = target.tracingManager;
+ WebInspector.targetManager.suspendReload(target);
+ profilingStartedPromise.then(tracingManager.start.bind(tracingManager, this, categories, options, onTraceStarted));
/**
- * @param {string} categories
- * @param {boolean=} enableJSSampling
- * @param {function(?string)=} callback
+ * @param {?string} error
*/
- _startRecordingWithCategories: function(categories, enableJSSampling, callback)
- {
- WebInspector.targetManager.suspendAllTargets();
- var profilingStartedPromise = enableJSSampling && !Runtime.experiments.isEnabled("timelineTracingJSProfile") ?
- this._startProfilingOnAllTargets() : Promise.resolve();
- var samplingFrequencyHz = WebInspector.moduleSetting("highResolutionCpuProfiling").get() ? 10000 : 1000;
- var options = "sampling-frequency=" + samplingFrequencyHz;
- var target = this._target;
- var tracingManager = target.tracingManager;
- WebInspector.targetManager.suspendReload(target);
- profilingStartedPromise.then(tracingManager.start.bind(tracingManager, this, categories, options, onTraceStarted));
- /**
- * @param {?string} error
- */
- function onTraceStarted(error)
- {
- WebInspector.targetManager.resumeReload(target);
- if (callback)
- callback(error);
- }
- },
+ function onTraceStarted(error) {
+ WebInspector.targetManager.resumeReload(target);
+ if (callback)
+ callback(error);
+ }
+ }
- /**
- * @override
- */
- tracingStarted: function()
- {
- this._tracingModel.reset();
- this._delegate.recordingStarted();
- },
+ /**
+ * @override
+ */
+ tracingStarted() {
+ this._tracingModel.reset();
+ this._delegate.recordingStarted();
+ }
- /**
- * @param {!Array.<!WebInspector.TracingManager.EventPayload>} events
- * @override
- */
- traceEventsCollected: function(events)
- {
- this._tracingModel.addEvents(events);
- },
+ /**
+ * @param {!Array.<!WebInspector.TracingManager.EventPayload>} events
+ * @override
+ */
+ traceEventsCollected(events) {
+ this._tracingModel.addEvents(events);
+ }
- /**
- * @override
- */
- tracingComplete: function()
- {
- this._tracingCompleteCallback();
- this._tracingCompleteCallback = null;
- },
+ /**
+ * @override
+ */
+ tracingComplete() {
+ this._tracingCompleteCallback();
+ this._tracingCompleteCallback = null;
+ }
- _allSourcesFinished: function()
- {
- this._injectCpuProfileEvents();
- this._tracingModel.tracingComplete();
- this._delegate.loadingComplete(true);
- },
+ _allSourcesFinished() {
+ this._injectCpuProfileEvents();
+ this._tracingModel.tracingComplete();
+ this._delegate.loadingComplete(true);
+ }
- /**
- * @param {number} pid
- * @param {number} tid
- * @param {?ProfilerAgent.Profile} cpuProfile
- */
- _injectCpuProfileEvent: function(pid, tid, cpuProfile)
- {
- if (!cpuProfile)
- return;
- var cpuProfileEvent = /** @type {!WebInspector.TracingManager.EventPayload} */ ({
- cat: WebInspector.TracingModel.DevToolsMetadataEventCategory,
- ph: WebInspector.TracingModel.Phase.Instant,
- ts: this._tracingModel.maximumRecordTime() * 1000,
- pid: pid,
- tid: tid,
- name: WebInspector.TimelineModel.RecordType.CpuProfile,
- args: { data: { cpuProfile: cpuProfile } }
- });
- this._tracingModel.addEvents([cpuProfileEvent]);
- },
+ /**
+ * @param {number} pid
+ * @param {number} tid
+ * @param {?ProfilerAgent.Profile} cpuProfile
+ */
+ _injectCpuProfileEvent(pid, tid, cpuProfile) {
+ if (!cpuProfile)
+ return;
+ var cpuProfileEvent = /** @type {!WebInspector.TracingManager.EventPayload} */ ({
+ cat: WebInspector.TracingModel.DevToolsMetadataEventCategory,
+ ph: WebInspector.TracingModel.Phase.Instant,
+ ts: this._tracingModel.maximumRecordTime() * 1000,
+ pid: pid,
+ tid: tid,
+ name: WebInspector.TimelineModel.RecordType.CpuProfile,
+ args: {data: {cpuProfile: cpuProfile}}
+ });
+ this._tracingModel.addEvents([cpuProfileEvent]);
+ }
- _injectCpuProfileEvents: function()
- {
- if (!this._cpuProfiles)
- return;
+ _injectCpuProfileEvents() {
+ if (!this._cpuProfiles)
+ return;
- var metadataEventTypes = WebInspector.TimelineModel.DevToolsMetadataEvent;
- var metadataEvents = this._tracingModel.devToolsMetadataEvents();
- var mainMetaEvent = metadataEvents.filter(event => event.name === metadataEventTypes.TracingStartedInPage).peekLast();
- if (!mainMetaEvent)
- return;
+ var metadataEventTypes = WebInspector.TimelineModel.DevToolsMetadataEvent;
+ var metadataEvents = this._tracingModel.devToolsMetadataEvents();
+ var mainMetaEvent =
+ metadataEvents.filter(event => event.name === metadataEventTypes.TracingStartedInPage).peekLast();
+ if (!mainMetaEvent)
+ return;
- var pid = mainMetaEvent.thread.process().id();
- var mainCpuProfile = this._cpuProfiles.get(this._target.id());
- this._injectCpuProfileEvent(pid, mainMetaEvent.thread.id(), mainCpuProfile);
+ var pid = mainMetaEvent.thread.process().id();
+ var mainCpuProfile = this._cpuProfiles.get(this._target.id());
+ this._injectCpuProfileEvent(pid, mainMetaEvent.thread.id(), mainCpuProfile);
- var workerMetaEvents = metadataEvents.filter(event => event.name === metadataEventTypes.TracingSessionIdForWorker);
- for (var metaEvent of workerMetaEvents) {
- var workerId = metaEvent.args["data"]["workerId"];
- var workerTarget = this._target.subTargetsManager ? this._target.subTargetsManager.targetForId(workerId) : null;
- if (!workerTarget)
- continue;
- var cpuProfile = this._cpuProfiles.get(workerTarget.id());
- this._injectCpuProfileEvent(pid, metaEvent.args["data"]["workerThreadId"], cpuProfile);
- }
- this._cpuProfiles = null;
- },
+ var workerMetaEvents = metadataEvents.filter(event => event.name === metadataEventTypes.TracingSessionIdForWorker);
+ for (var metaEvent of workerMetaEvents) {
+ var workerId = metaEvent.args['data']['workerId'];
+ var workerTarget = this._target.subTargetsManager ? this._target.subTargetsManager.targetForId(workerId) : null;
+ if (!workerTarget)
+ continue;
+ var cpuProfile = this._cpuProfiles.get(workerTarget.id());
+ this._injectCpuProfileEvent(pid, metaEvent.args['data']['workerThreadId'], cpuProfile);
+ }
+ this._cpuProfiles = null;
+ }
- /**
- * @param {number} usage
- * @override
- */
- tracingBufferUsage: function(usage)
- {
- this._delegate.recordingProgress(usage);
- },
+ /**
+ * @param {number} usage
+ * @override
+ */
+ tracingBufferUsage(usage) {
+ this._delegate.recordingProgress(usage);
+ }
- /**
- * @param {number} progress
- * @override
- */
- eventsRetrievalProgress: function(progress)
- {
- this._delegate.loadingProgress(progress);
- }
+ /**
+ * @param {number} progress
+ * @override
+ */
+ eventsRetrievalProgress(progress) {
+ this._delegate.loadingProgress(progress);
+ }
};

Powered by Google App Engine
This is Rietveld 408576698