Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js
index 7cb7d9703b51d5d7ee0995e8bdd60be1722cba07..6691c29c742bc735a0aa255283d7cd8d08952fd2 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js
@@ -3,125 +3,120 @@
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
-
/**
- * @constructor
- * @extends {WebInspector.FilteredListWidget.Delegate}
- * @param {!WebInspector.UISourceCode} uiSourceCode
- * @param {function(number, number)} selectItemCallback
+ * @unrestricted
*/
-WebInspector.JavaScriptOutlineDialog = function(uiSourceCode, selectItemCallback)
-{
- WebInspector.FilteredListWidget.Delegate.call(this, []);
+WebInspector.JavaScriptOutlineDialog = class extends WebInspector.FilteredListWidget.Delegate {
+ /**
+ * @param {!WebInspector.UISourceCode} uiSourceCode
+ * @param {function(number, number)} selectItemCallback
+ */
+ constructor(uiSourceCode, selectItemCallback) {
+ super([]);
this._functionItems = [];
this._selectItemCallback = selectItemCallback;
- WebInspector.formatterWorkerPool.runChunkedTask("javaScriptOutline", {content: uiSourceCode.workingCopy() }, this._didBuildOutlineChunk.bind(this));
-};
+ WebInspector.formatterWorkerPool.runChunkedTask(
+ 'javaScriptOutline', {content: uiSourceCode.workingCopy()}, this._didBuildOutlineChunk.bind(this));
+ }
-/**
- * @param {!WebInspector.UISourceCode} uiSourceCode
- * @param {function(number, number)} selectItemCallback
- */
-WebInspector.JavaScriptOutlineDialog.show = function(uiSourceCode, selectItemCallback)
-{
- WebInspector.JavaScriptOutlineDialog._instanceForTests = new WebInspector.JavaScriptOutlineDialog(uiSourceCode, selectItemCallback);
+ /**
+ * @param {!WebInspector.UISourceCode} uiSourceCode
+ * @param {function(number, number)} selectItemCallback
+ */
+ static show(uiSourceCode, selectItemCallback) {
+ WebInspector.JavaScriptOutlineDialog._instanceForTests =
+ new WebInspector.JavaScriptOutlineDialog(uiSourceCode, selectItemCallback);
new WebInspector.FilteredListWidget(WebInspector.JavaScriptOutlineDialog._instanceForTests).showAsDialog();
-};
-
-WebInspector.JavaScriptOutlineDialog.prototype = {
- /**
- * @param {?MessageEvent} event
- */
- _didBuildOutlineChunk: function(event)
- {
- if (!event) {
- this.dispose();
- this.refresh();
- return;
- }
- var data = /** @type {!WebInspector.JavaScriptOutlineDialog.MessageEventData} */ (event.data);
- var chunk = data.chunk;
- for (var i = 0; i < chunk.length; ++i)
- this._functionItems.push(chunk[i]);
+ }
- if (data.isLastChunk)
- this.dispose();
+ /**
+ * @param {?MessageEvent} event
+ */
+ _didBuildOutlineChunk(event) {
+ if (!event) {
+ this.dispose();
+ this.refresh();
+ return;
+ }
+ var data = /** @type {!WebInspector.JavaScriptOutlineDialog.MessageEventData} */ (event.data);
+ var chunk = data.chunk;
+ for (var i = 0; i < chunk.length; ++i)
+ this._functionItems.push(chunk[i]);
- this.refresh();
- },
+ if (data.isLastChunk)
+ this.dispose();
- /**
- * @override
- * @return {number}
- */
- itemCount: function()
- {
- return this._functionItems.length;
- },
+ this.refresh();
+ }
- /**
- * @override
- * @param {number} itemIndex
- * @return {string}
- */
- itemKeyAt: function(itemIndex)
- {
- var item = this._functionItems[itemIndex];
- return item.name + (item.arguments ? item.arguments : "");
- },
+ /**
+ * @override
+ * @return {number}
+ */
+ itemCount() {
+ return this._functionItems.length;
+ }
- /**
- * @override
- * @param {number} itemIndex
- * @param {string} query
- * @return {number}
- */
- itemScoreAt: function(itemIndex, query)
- {
- var item = this._functionItems[itemIndex];
- var methodName = query.split("(")[0];
- if (methodName.toLowerCase() === item.name.toLowerCase())
- return 1 / (1 + item.line);
- return -item.line - 1;
- },
+ /**
+ * @override
+ * @param {number} itemIndex
+ * @return {string}
+ */
+ itemKeyAt(itemIndex) {
+ var item = this._functionItems[itemIndex];
+ return item.name + (item.arguments ? item.arguments : '');
+ }
- /**
- * @override
- * @param {number} itemIndex
- * @param {string} query
- * @param {!Element} titleElement
- * @param {!Element} subtitleElement
- */
- renderItem: function(itemIndex, query, titleElement, subtitleElement)
- {
- var item = this._functionItems[itemIndex];
- titleElement.textContent = item.name + (item.arguments ? item.arguments : "");
- this.highlightRanges(titleElement, query);
- subtitleElement.textContent = ":" + (item.line + 1);
- },
+ /**
+ * @override
+ * @param {number} itemIndex
+ * @param {string} query
+ * @return {number}
+ */
+ itemScoreAt(itemIndex, query) {
+ var item = this._functionItems[itemIndex];
+ var methodName = query.split('(')[0];
+ if (methodName.toLowerCase() === item.name.toLowerCase())
+ return 1 / (1 + item.line);
+ return -item.line - 1;
+ }
- /**
- * @override
- * @param {?number} itemIndex
- * @param {string} promptValue
- */
- selectItem: function(itemIndex, promptValue)
- {
- if (itemIndex === null)
- return;
- var lineNumber = this._functionItems[itemIndex].line;
- if (!isNaN(lineNumber) && lineNumber >= 0)
- this._selectItemCallback(lineNumber, this._functionItems[itemIndex].column);
- },
+ /**
+ * @override
+ * @param {number} itemIndex
+ * @param {string} query
+ * @param {!Element} titleElement
+ * @param {!Element} subtitleElement
+ */
+ renderItem(itemIndex, query, titleElement, subtitleElement) {
+ var item = this._functionItems[itemIndex];
+ titleElement.textContent = item.name + (item.arguments ? item.arguments : '');
+ this.highlightRanges(titleElement, query);
+ subtitleElement.textContent = ':' + (item.line + 1);
+ }
- dispose: function()
- {
- },
+ /**
+ * @override
+ * @param {?number} itemIndex
+ * @param {string} promptValue
+ */
+ selectItem(itemIndex, promptValue) {
+ if (itemIndex === null)
+ return;
+ var lineNumber = this._functionItems[itemIndex].line;
+ if (!isNaN(lineNumber) && lineNumber >= 0)
+ this._selectItemCallback(lineNumber, this._functionItems[itemIndex].column);
+ }
- __proto__: WebInspector.FilteredListWidget.Delegate.prototype
+ /**
+ * @override
+ */
+ dispose() {
+ }
};
+
/**
* @typedef {{isLastChunk: boolean, chunk: !Array.<!{selectorText: string, lineNumber: number, columnNumber: number}>}}
*/

Powered by Google App Engine
This is Rietveld 408576698