Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: third_party/WebKit/Source/devtools/front_end/terminal/TerminalWidget.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/terminal/TerminalWidget.js
diff --git a/third_party/WebKit/Source/devtools/front_end/terminal/TerminalWidget.js b/third_party/WebKit/Source/devtools/front_end/terminal/TerminalWidget.js
index c6c9a64db44ec344c718159745b51e62938cf7de..3f44032107a07e4c8b4fbf7db614ed762f355783 100644
--- a/third_party/WebKit/Source/devtools/front_end/terminal/TerminalWidget.js
+++ b/third_party/WebKit/Source/devtools/front_end/terminal/TerminalWidget.js
@@ -1,139 +1,129 @@
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
/**
- * @constructor
- * @extends {WebInspector.VBox}
+ * @unrestricted
*/
-WebInspector.TerminalWidget = function()
-{
- WebInspector.VBox.call(this, false);
- this.registerRequiredCSS("terminal/xterm.js/build/xterm.css");
- this.registerRequiredCSS("terminal/terminal.css");
- this.element.classList.add("terminal-root");
- this.element.addEventListener("mousemove", this._mouseMove.bind(this), false);
+WebInspector.TerminalWidget = class extends WebInspector.VBox {
+ constructor() {
+ super(false);
+ this.registerRequiredCSS('terminal/xterm.js/build/xterm.css');
+ this.registerRequiredCSS('terminal/terminal.css');
+ this.element.classList.add('terminal-root');
+ this.element.addEventListener('mousemove', this._mouseMove.bind(this), false);
this._init();
this._linkifier = new WebInspector.Linkifier();
this._linkifyFunction = this._linkifyURL.bind(this);
-};
-
-WebInspector.TerminalWidget.prototype = {
- _init: function()
- {
- WebInspector.serviceManager.createRemoteService("Terminal").then(this._initialized.bind(this));
- },
+ }
- /**
- * @param {?WebInspector.ServiceManager.Service} backend
- */
- _initialized: function(backend)
- {
- if (!backend) {
- if (!this._unavailableLabel) {
- this._unavailableLabel = this.element.createChild("div", "terminal-error-message fill");
- this._unavailableLabel.createChild("div").textContent = WebInspector.UIString("Terminal service is not available");
- }
- if (this.isShowing())
- setTimeout(this._init.bind(this), 2000);
- return;
- }
+ _init() {
+ WebInspector.serviceManager.createRemoteService('Terminal').then(this._initialized.bind(this));
+ }
- if (this._unavailableLabel) {
- this._unavailableLabel.remove();
- delete this._unavailableLabel;
- }
+ /**
+ * @param {?WebInspector.ServiceManager.Service} backend
+ */
+ _initialized(backend) {
+ if (!backend) {
+ if (!this._unavailableLabel) {
+ this._unavailableLabel = this.element.createChild('div', 'terminal-error-message fill');
+ this._unavailableLabel.createChild('div').textContent =
+ WebInspector.UIString('Terminal service is not available');
+ }
+ if (this.isShowing())
+ setTimeout(this._init.bind(this), 2000);
+ return;
+ }
- this._backend = backend;
+ if (this._unavailableLabel) {
+ this._unavailableLabel.remove();
+ delete this._unavailableLabel;
+ }
- if (!this._term) {
- this._term = new Terminal({ cursorBlink: true });
- this._term.open(this.contentElement);
- this._term.on("data", data => {
- this._backend.send("write", { data: data });
- });
- this._term.fit();
- this._term.on("resize", size => {
- this._backend.send("resize", { cols: size.cols, rows: size.rows });
- });
- }
+ this._backend = backend;
- this._backend.send("init", { cols: this._term.cols, rows: this._term.rows });
- this._backend.on("data", result => {
- this._term.write(result.data);
- this._linkifyUpToDate = false;
- });
- this._backend.on("disposed", this._disposed.bind(this));
- },
+ if (!this._term) {
+ this._term = new Terminal({cursorBlink: true});
+ this._term.open(this.contentElement);
+ this._term.on('data', data => {
+ this._backend.send('write', {data: data});
+ });
+ this._term.fit();
+ this._term.on('resize', size => {
+ this._backend.send('resize', {cols: size.cols, rows: size.rows});
+ });
+ }
- _mouseMove: function()
- {
- if (this._linkifyUpToDate)
- return;
- if (this._term)
- this._linkify();
- this._linkifyUpToDate = true;
- },
+ this._backend.send('init', {cols: this._term.cols, rows: this._term.rows});
+ this._backend.on('data', result => {
+ this._term.write(result.data);
+ this._linkifyUpToDate = false;
+ });
+ this._backend.on('disposed', this._disposed.bind(this));
+ }
- onResize: function()
- {
- if (this._term)
- this._term.fit();
- },
+ _mouseMove() {
+ if (this._linkifyUpToDate)
+ return;
+ if (this._term)
+ this._linkify();
+ this._linkifyUpToDate = true;
+ }
- _disposed: function()
- {
- this._initialized(null);
- },
+ /**
+ * @override
+ */
+ onResize() {
+ if (this._term)
+ this._term.fit();
+ }
- /**
- * @override
- */
- wasDetachedFromHierarchy: function()
- {
- if (this._backend)
- this._backend.dispose();
- },
+ _disposed() {
+ this._initialized(null);
+ }
- _linkify: function()
- {
- if (!this._term)
- return;
- this._linkifier.reset();
- var rows = this._term.rowContainer.children;
- for (var i = 0; i < rows.length; i++)
- this._linkifyTerminalLine(rows[i]);
- },
+ /**
+ * @override
+ */
+ wasDetachedFromHierarchy() {
+ if (this._backend)
+ this._backend.dispose();
+ }
- /**
- * @param {!Node} line
- */
- _linkifyTerminalLine: function(line)
- {
- var node = line.firstChild;
- while (node) {
- if (node.nodeType !== Node.TEXT_NODE) {
- node = node.nextSibling;
- continue;
- }
- var nextNode = node.nextSibling;
- node.remove();
- var linkified = WebInspector.linkifyStringAsFragmentWithCustomLinkifier(node.textContent, this._linkifyFunction);
- line.insertBefore(linkified, nextNode);
- node = nextNode;
- }
- },
+ _linkify() {
+ if (!this._term)
+ return;
+ this._linkifier.reset();
+ var rows = this._term.rowContainer.children;
+ for (var i = 0; i < rows.length; i++)
+ this._linkifyTerminalLine(rows[i]);
+ }
- /**
- * @param {string} title
- * @param {string} url
- * @param {number=} lineNumber
- * @param {number=} columnNumber
- */
- _linkifyURL: function(title, url, lineNumber, columnNumber)
- {
- return this._linkifier.linkifyScriptLocation(null, null, url, lineNumber || 0, columnNumber || 0);
- },
+ /**
+ * @param {!Node} line
+ */
+ _linkifyTerminalLine(line) {
+ var node = line.firstChild;
+ while (node) {
+ if (node.nodeType !== Node.TEXT_NODE) {
+ node = node.nextSibling;
+ continue;
+ }
+ var nextNode = node.nextSibling;
+ node.remove();
+ var linkified = WebInspector.linkifyStringAsFragmentWithCustomLinkifier(node.textContent, this._linkifyFunction);
+ line.insertBefore(linkified, nextNode);
+ node = nextNode;
+ }
+ }
- __proto__: WebInspector.VBox.prototype
+ /**
+ * @param {string} title
+ * @param {string} url
+ * @param {number=} lineNumber
+ * @param {number=} columnNumber
+ */
+ _linkifyURL(title, url, lineNumber, columnNumber) {
+ return this._linkifier.linkifyScriptLocation(null, null, url, lineNumber || 0, columnNumber || 0);
+ }
};

Powered by Google App Engine
This is Rietveld 408576698