Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
index 3b5f34bf7d85e0f2f98a8c1ae53885f857af44cd..bfbf65df5388e653df7437b385edf331cc7433a4 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
@@ -1167,14 +1167,14 @@ WebInspector.DataGrid.prototype = {
var rightEdgeOfNextColumn = leftEdgeOfPreviousColumn + firstRowCells[leftCellIndex].offsetWidth + firstRowCells[rightCellIndex].offsetWidth;
// Give each column some padding so that they don't disappear.
- var leftMinimum = leftEdgeOfPreviousColumn + this.ColumnResizePadding;
- var rightMaximum = rightEdgeOfNextColumn - this.ColumnResizePadding;
+ var leftMinimum = leftEdgeOfPreviousColumn + WebInspector.DataGrid.ColumnResizePadding;
+ var rightMaximum = rightEdgeOfNextColumn - WebInspector.DataGrid.ColumnResizePadding;
if (leftMinimum > rightMaximum)
return;
dragPoint = Number.constrain(dragPoint, leftMinimum, rightMaximum);
- var position = (dragPoint - this.CenterResizerOverBorderAdjustment);
+ var position = (dragPoint - WebInspector.DataGrid.CenterResizerOverBorderAdjustment);
resizer.__position = position;
resizer.style.left = position + "px";
@@ -1234,13 +1234,12 @@ WebInspector.DataGrid.prototype = {
return this._dataGridWidget;
},
- ColumnResizePadding: 24,
-
- CenterResizerOverBorderAdjustment: 3,
-
__proto__: WebInspector.Object.prototype
};
+WebInspector.DataGrid.ColumnResizePadding = 24;
+WebInspector.DataGrid.CenterResizerOverBorderAdjustment = 3;
+
/** @enum {string} */
WebInspector.DataGrid.ResizeMethod = {
Nearest: "nearest",
@@ -1288,15 +1287,15 @@ WebInspector.DataGridNode = function(data, hasChildren)
this.nextSibling = null;
/** @type {number} */
this.disclosureToggleWidth = 10;
-};
-WebInspector.DataGridNode.prototype = {
/** @type {boolean} */
- selectable: true,
+ this.selectable = true;
/** @type {boolean} */
- _isRoot: false,
+ this._isRoot = false;
+};
+WebInspector.DataGridNode.prototype = {
/**
* @return {!Element}
*/
@@ -1347,6 +1346,9 @@ WebInspector.DataGridNode.prototype = {
return this._data;
},
+ /**
+ * @param {!Object.<string, *>} x
+ */
set data(x)
{
this._data = x || {};
@@ -1375,6 +1377,9 @@ WebInspector.DataGridNode.prototype = {
return true;
},
+ /**
+ * @param {boolean} x
+ */
set revealed(x)
{
if (this._revealed === x)
@@ -1397,6 +1402,9 @@ WebInspector.DataGridNode.prototype = {
return this._hasChildren;
},
+ /**
+ * @param {boolean} x
+ */
set hasChildren(x)
{
if (this._hasChildren === x)
@@ -1441,6 +1449,9 @@ WebInspector.DataGridNode.prototype = {
return this._shouldRefreshChildren;
},
+ /**
+ * @param {boolean} x
+ */
set shouldRefreshChildren(x)
{
this._shouldRefreshChildren = x;
@@ -1456,6 +1467,9 @@ WebInspector.DataGridNode.prototype = {
return this._selected;
},
+ /**
+ * @param {boolean} x
+ */
set selected(x)
{
if (x)
@@ -1472,6 +1486,9 @@ WebInspector.DataGridNode.prototype = {
return this._expanded;
},
+ /**
+ * @param {boolean} x
+ */
set expanded(x)
{
if (x)
@@ -2029,7 +2046,7 @@ WebInspector.DataGridWidget.prototype = {
*/
detachChildWidgets: function()
{
- WebInspector.Widget.prototype.detachChildWidgets.call(this);
+ WebInspector.VBox.prototype.detachChildWidgets.call(this);
for (var dataGrid of this._dataGrids)
this.element.removeChild(dataGrid.element);
this._dataGrids = [];

Powered by Google App Engine
This is Rietveld 408576698