Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: scripts/slave/recipe_modules/auto_bisect_staging/bisector.py

Issue 2466113002: Adding display_values property for each revision. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
diff --git a/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py b/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
index a09f296bb6c23e6a4f5a9403b06e3875aab5ffad..c4b3089d8b9e69651431dcd3b9f8bf2b60e1e75d 100644
--- a/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
+++ b/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
@@ -530,8 +530,8 @@ class Bisector(object):
if (self.lkgr and self.lkgr.test_run_count and self.fkbr and
self.fkbr.test_run_count):
result += '\n' + '\n'.join([
- 'LKGR values: %r' % list(self.lkgr.debug_values),
- 'FKBR values: %r' % list(self.fkbr.debug_values),
+ 'LKGR values: %r' % list(self.lkgr.display_values),
+ 'FKBR values: %r' % list(self.fkbr.display_values),
])
return result
@@ -539,7 +539,7 @@ class Bisector(object):
"""Returns a string table showing revisions and their values."""
header = [['Revision', 'Values']]
with self._api.m.step.nest('Resolving hashes'):
- rows = [[r.revision_string(), str(r.debug_values)]
+ rows = [[r.revision_string(), str(r.display_values)]
for r in self.revisions]
return self._pretty_table(header + rows)
@@ -807,8 +807,7 @@ class Bisector(object):
'revision_string': r.revision_string(),
'mean_value': r.mean,
'std_dev': r.std_dev,
- 'values': (r.debug_values if self.test_type == 'perf'
- else r.return_codes),
+ 'values': r.display_values,
'result': 'good' if r.good else 'bad' if r.bad else 'unknown',
})
return revision_rows
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698