ash/common/devtools/ash_devtools_unittest.cc - Issue 2466073003: Push updates to inspector when windows are added, destroyed or reorganized

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/common/devtools/ash_devtools_unittest.cc

Issue 2466073003: Push updates to inspector when windows are added, destroyed or reorganized (Closed)

Patch Set: Push updates to inspector when windows are added, destroyed or reorganized Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ash/common/devtools/ash_devtools_dom_agent.cc ('K') | « ash/common/devtools/ash_devtools_dom_agent.cc ('k') | components/ui_devtools/protocol.json » ('j') | components/ui_devtools/protocol.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/common/devtools/ash_devtools_dom_agent.h"	5 #include "ash/common/devtools/ash_devtools_dom_agent.h"

6	6

7 #include "ash/common/test/ash_test.h"	7 #include "ash/common/test/ash_test.h"

8 #include "ash/common/wm_lookup.h"	8 #include "ash/common/wm_lookup.h"

9 #include "ash/common/wm_shell.h"	9 #include "ash/common/wm_shell.h"

10 #include "ash/common/wm_window.h"	10 #include "ash/common/wm_window.h"

(...skipping 123 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
134 DOM::Node* parent_node = FindInRoot(parent_window, root.get());	134 DOM::Node* parent_node = FindInRoot(parent_window, root.get());

135 DOM::Node* widget_node = FindInRoot(widget.get(), root.get());	135 DOM::Node* widget_node = FindInRoot(widget.get(), root.get());

136	136

137 EXPECT_TRUE(parent_node);	137 EXPECT_TRUE(parent_node);

138 EXPECT_TRUE(widget_node);	138 EXPECT_TRUE(widget_node);

139 Compare(child_window, parent_node->getChildren(nullptr)->get(0));	139 Compare(child_window, parent_node->getChildren(nullptr)->get(0));

140 Compare(widget->GetRootView(), widget_node->getChildren(nullptr)->get(0));	140 Compare(widget->GetRootView(), widget_node->getChildren(nullptr)->get(0));

141 Compare(	141 Compare(

142 child_view,	142 child_view,

143 widget_node->getChildren(nullptr)->get(0)->getChildren(nullptr)->get(1));	143 widget_node->getChildren(nullptr)->get(0)->getChildren(nullptr)->get(1));

	144 // TODO(mhashmi): Remove this call and mock FrontendChannel

	145 dom_agent()->disable(nullptr);

144 }	146 }

145	147

146 } // namespace ash	148 } // namespace ash

OLD	NEW