Issue 246603003: Eliminate RETURN_IF_EMPTY_HANDLE macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246603003: Eliminate RETURN_IF_EMPTY_HANDLE macro (Closed)

Created:
6 years, 8 months ago by mvstanton

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Use MaybeHandles in Compiler to indicate failure instead of a null Handle. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20890

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -58 lines)			Patch
M	src/compiler.h	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	src/compiler.cc	View	9 chunks	+40 lines, -30 lines	0 comments	Download
M	src/debug.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/runtime.cc	View	3 chunks	+15 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

Hi Yang, these changes allow us to remove certain macros. Thanks for the look, --Michael

6 years, 8 months ago (2014-04-22 11:56:39 UTC) #1

Yang

On 2014/04/22 11:56:39, mvstanton wrote: > Hi Yang, these changes allow us to remove certain ...

6 years, 8 months ago (2014-04-22 12:22:32 UTC) #2

mvstanton

6 years, 8 months ago (2014-04-22 14:55:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20890 (presubmit successful).