Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2466023003: Makes CaptureController be created and owned by WMState (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes CaptureController be created and owned by WMState CaptureController is a singleton, and I need a way to get at it for aura-mus. This moves ownership to WMState. BUG=659155 TEST=none R=erg@chromium.org Committed: https://crrev.com/c09003263119e2866ff402bc98d5812360aec4d3 Cr-Commit-Position: refs/heads/master@{#428938}

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : fix ash #

Patch Set 4 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -66 lines) Patch
M ash/test/ash_test_helper.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M ui/views/test/views_test_helper_aura.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/wm/core/capture_controller.h View 1 2 4 chunks +6 lines, -12 lines 0 comments Download
M ui/wm/core/capture_controller.cc View 4 chunks +17 lines, -28 lines 0 comments Download
M ui/wm/core/capture_controller_unittest.cc View 4 chunks +2 lines, -18 lines 0 comments Download
M ui/wm/core/wm_state.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/wm/core/wm_state.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
sky
4 years, 1 month ago (2016-10-31 23:23:25 UTC) #1
Elliot Glaysher
lgtm
4 years, 1 month ago (2016-10-31 23:51:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466023003/20001
4 years, 1 month ago (2016-11-01 02:17:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/328308)
4 years, 1 month ago (2016-11-01 02:32:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466023003/40001
4 years, 1 month ago (2016-11-01 02:41:33 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/308527)
4 years, 1 month ago (2016-11-01 03:24:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466023003/60001
4 years, 1 month ago (2016-11-01 04:13:36 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-01 04:53:08 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 04:54:51 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c09003263119e2866ff402bc98d5812360aec4d3
Cr-Commit-Position: refs/heads/master@{#428938}

Powered by Google App Engine
This is Rietveld 408576698