Unify some code

core/fpdfapi/parser/cpdf_document_unittest.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/fpdfapi/parser/cpdf_document.h"
 
 #include <memory>
 
 #include "core/fpdfapi/cpdf_modulemgr.h"
 #include "core/fpdfapi/parser/cpdf_array.h"
 #include "core/fpdfapi/parser/cpdf_dictionary.h"
+#include "core/fpdfapi/parser/cpdf_linearized.h"
 #include "core/fpdfapi/parser/cpdf_parser.h"
 #include "core/fxcrt/fx_memory.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 using ScopedDictionary =
     std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>>;
 
 CPDF_Dictionary* CreatePageTreeNode(CPDF_Array* kids,
@@ skipping 50 matching lines @@
     m_pOwnedRootDict->SetReferenceFor("Pages", this,
                                       AddIndirectObject(pagesDict));
     m_pRootDict = m_pOwnedRootDict.get();
     m_PageList.SetSize(7);
   }
 
  private:
   std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>>
       m_pOwnedRootDict;
 };
+
+class TestLinearized : public CPDF_Linearized {
+ public:
+  TestLinearized(CPDF_Dictionary* dict) : CPDF_Linearized(dict) {}

[Lei Zhang, 2016/11/04 23:02:15]

add "explicit"

[snake, 2016/11/04 23:27:36]

Done.

+};
 }  // namespace
 
 class cpdf_document_test : public testing::Test {
  public:
   void SetUp() override {
     CPDF_ModuleMgr* module_mgr = CPDF_ModuleMgr::Get();
     module_mgr->InitPageModule();
   }
   void TearDown() override {}
 };
@@ skipping 22 matching lines @@
   }
   CPDF_Dictionary* page = document->GetPage(7);
   EXPECT_FALSE(page);
 }
 
 TEST_F(cpdf_document_test, UseCachedPageObjNumIfHaveNotPagesDict) {
   // ObjNum can be added in CPDF_DataAvail::IsPageAvail, and PagesDict
   // can be not exists in this case.
   // (case, when hint table is used to page check in CPDF_DataAvail).
   CPDF_Document document(pdfium::MakeUnique<CPDF_Parser>());
-  ScopedDictionary dict(new CPDF_Dictionary());
+  UniqueDictionary dict(new CPDF_Dictionary());

[Lei Zhang, 2016/11/04 23:02:15]

pdfium::MakeUnique<CPDF_Dictionary>()

[snake, 2016/11/04 23:27:36]

CPDF_Dictionary should use custom deleter.

+  dict->SetBooleanFor("Linearized", true);
   const int page_count = 100;
   dict->SetIntegerFor("N", page_count);
-  document.LoadLinearizedDoc(dict.get());
+  TestLinearized linearized(dict.get());
+  document.LoadLinearizedDoc(&linearized);
   ASSERT_EQ(page_count, document.GetPageCount());
   CPDF_Object* page_stub = new CPDF_Dictionary();
   const uint32_t obj_num = document.AddIndirectObject(page_stub);
   const int test_page_num = 33;
 
   EXPECT_FALSE(document.IsPageLoaded(test_page_num));
   EXPECT_EQ(nullptr, document.GetPage(test_page_num));
 
   document.SetPageObjNum(test_page_num, obj_num);
 
   EXPECT_TRUE(document.IsPageLoaded(test_page_num));
   EXPECT_EQ(page_stub, document.GetPage(test_page_num));
 }