Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: components/variations/field_trial_config/BUILD.gn

Issue 2465953002: Move Field Trial Utils from chrome/common/variations to components/variations/field_trial_util (Closed)
Patch Set: Moved to components/variations/field_trial_util and chrome switches Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/variations/BUILD.gn ('k') | components/variations/field_trial_config/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/field_trial_config/BUILD.gn
diff --git a/chrome/common/variations/BUILD.gn b/components/variations/field_trial_config/BUILD.gn
similarity index 54%
rename from chrome/common/variations/BUILD.gn
rename to components/variations/field_trial_config/BUILD.gn
index 517865b0a63abd4ba9ea7fc0afbaa2e0530cd2cb..6dbe3263ac2886a11591cb66dc81c20d41f12aa4 100644
--- a/chrome/common/variations/BUILD.gn
+++ b/components/variations/field_trial_config/BUILD.gn
@@ -2,8 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-action("fieldtrial_testing_config_action") {
- visibility = [ ":fieldtrial_testing_config" ]
+action("field_trial_testing_config_action") {
+ visibility = [ ":field_trial_config" ]
script = "//tools/variations/fieldtrial_to_struct.py"
source = "//testing/variations/fieldtrial_testing_config.json"
@@ -22,17 +22,39 @@ action("fieldtrial_testing_config_action") {
args = [
rebase_path(source, root_build_dir),
"--destbase=" + rebase_path(target_gen_dir, root_build_dir),
- "--namespace=chrome_variations",
+ "--namespace=variations",
"--schema=" +
- rebase_path("fieldtrial_testing_config_schema.json", root_build_dir),
+ rebase_path("field_trial_testing_config_schema.json", root_build_dir),
"--platform=" + current_os,
"--output=$out_name",
]
}
-source_set("fieldtrial_testing_config") {
- sources = get_target_outputs(":fieldtrial_testing_config_action")
+static_library("field_trial_config") {
+ sources = [
+ "field_trial_util.cc",
+ "field_trial_util.h",
+ ]
+
+ sources += get_target_outputs(":field_trial_testing_config_action")
+
+ deps = [
+ ":field_trial_testing_config_action",
+ "//base",
+ "//components/variations",
+ "//net",
+ ]
+}
+
+source_set("unit_tests") {
+ testonly = true
+ sources = [
+ "field_trial_util_unittest.cc",
+ ]
deps = [
- ":fieldtrial_testing_config_action",
+ ":field_trial_config",
+ "//base",
+ "//components/variations",
+ "//testing/gtest",
]
}
« no previous file with comments | « components/variations/BUILD.gn ('k') | components/variations/field_trial_config/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698