Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2465953002: Move Field Trial Utils from chrome/common/variations to components/variations/field_trial_util (Closed)
Patch Set: Moved to components/variations/field_trial_util and chrome switches Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 6e3e14b2cc96c364e574a4d97e1b5cb07c1a5512..9431bf5f8fd007d83f1ade396bbe7192c1a0ebf3 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -116,7 +116,6 @@
#include "chrome/common/pref_names.h"
#include "chrome/common/profiling.h"
#include "chrome/common/stack_sampling_configuration.h"
-#include "chrome/common/variations/variations_util.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/installer/util/google_update_settings.h"
#include "components/component_updater/component_updater_service.h"
@@ -142,6 +141,7 @@
#include "components/task_scheduler_util/initialization_util.h"
#include "components/tracing/common/tracing_switches.h"
#include "components/translate/core/browser/translate_download_manager.h"
+#include "components/variations/field_trial_config/field_trial_util.h"
#include "components/variations/pref_names.h"
#include "components/variations/service/variations_service.h"
#include "components/variations/variations_associated_data.h"
@@ -696,10 +696,12 @@ void ChromeBrowserMainParts::SetupFieldTrials() {
base::FieldTrial::EnableBenchmarking();
}
- if (command_line->HasSwitch(switches::kForceFieldTrialParams)) {
- bool result = chrome_variations::AssociateParamsFromString(
- command_line->GetSwitchValueASCII(switches::kForceFieldTrialParams));
- CHECK(result) << "Invalid --" << switches::kForceFieldTrialParams
+ if (command_line->HasSwitch(variations::switches::kForceFieldTrialParams)) {
+ bool result = variations::AssociateParamsFromString(
+ command_line->GetSwitchValueASCII(
+ variations::switches::kForceFieldTrialParams));
+ CHECK(result) << "Invalid --"
+ << variations::switches::kForceFieldTrialParams
<< " list specified.";
}
@@ -743,10 +745,11 @@ void ChromeBrowserMainParts::SetupFieldTrials() {
command_line->GetSwitchValueASCII(switches::kDisableFeatures));
#if defined(FIELDTRIAL_TESTING_ENABLED)
- if (!command_line->HasSwitch(switches::kDisableFieldTrialTestingConfig) &&
+ if (!command_line->HasSwitch(
+ variations::switches::kDisableFieldTrialTestingConfig) &&
!command_line->HasSwitch(switches::kForceFieldTrials) &&
!command_line->HasSwitch(variations::switches::kVariationsServerURL)) {
- chrome_variations::AssociateDefaultFieldTrialConfig(feature_list.get());
+ variations::AssociateDefaultFieldTrialConfig(feature_list.get());
}
#endif // defined(FIELDTRIAL_TESTING_ENABLED)
« no previous file with comments | « chrome/browser/chrome_browser_field_trials_desktop.cc ('k') | chrome/browser/plugins/flash_permission_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698