| OLD | NEW |
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/common/variations/variations_util.h" | 5 #include "components/variations/field_trial_config/field_trial_util.h" |
| 6 | 6 |
| 7 #include <memory> | 7 #include <memory> |
| 8 #include <utility> | 8 #include <utility> |
| 9 | 9 |
| 10 #include "base/command_line.h" | 10 #include "base/command_line.h" |
| 11 #include "base/feature_list.h" | 11 #include "base/feature_list.h" |
| 12 #include "base/macros.h" | 12 #include "base/macros.h" |
| 13 #include "base/metrics/field_trial.h" | 13 #include "base/metrics/field_trial.h" |
| 14 #include "chrome/common/variations/fieldtrial_testing_config.h" | 14 #include "components/variations/field_trial_config/fieldtrial_testing_config.h" |
| 15 #include "components/variations/variations_associated_data.h" | 15 #include "components/variations/variations_associated_data.h" |
| 16 #include "testing/gtest/include/gtest/gtest.h" | 16 #include "testing/gtest/include/gtest/gtest.h" |
| 17 | 17 |
| 18 namespace chrome_variations { | 18 namespace variations { |
| 19 | 19 |
| 20 class VariationsUtilTest : public ::testing::Test { | 20 namespace { |
| 21 |
| 22 class FieldTrialUtilTest : public ::testing::Test { |
| 21 public: | 23 public: |
| 22 VariationsUtilTest() : field_trial_list_(nullptr) {} | 24 FieldTrialUtilTest() : field_trial_list_(nullptr) {} |
| 23 | 25 |
| 24 ~VariationsUtilTest() override { | 26 ~FieldTrialUtilTest() override { |
| 25 // Ensure that the maps are cleared between tests, since they are stored as | 27 // Ensure that the maps are cleared between tests, since they are stored as |
| 26 // process singletons. | 28 // process singletons. |
| 27 variations::testing::ClearAllVariationIDs(); | 29 variations::testing::ClearAllVariationIDs(); |
| 28 variations::testing::ClearAllVariationParams(); | 30 variations::testing::ClearAllVariationParams(); |
| 29 } | 31 } |
| 30 | 32 |
| 31 private: | 33 private: |
| 32 base::FieldTrialList field_trial_list_; | 34 base::FieldTrialList field_trial_list_; |
| 33 | 35 |
| 34 DISALLOW_COPY_AND_ASSIGN(VariationsUtilTest); | 36 DISALLOW_COPY_AND_ASSIGN(FieldTrialUtilTest); |
| 35 }; | 37 }; |
| 36 | 38 |
| 37 TEST_F(VariationsUtilTest, AssociateParamsFromString) { | 39 } // namespace |
| 40 |
| 41 TEST_F(FieldTrialUtilTest, AssociateParamsFromString) { |
| 38 const std::string kTrialName = "AssociateVariationParams"; | 42 const std::string kTrialName = "AssociateVariationParams"; |
| 39 const std::string kVariationsString = | 43 const std::string kVariationsString = |
| 40 "AssociateVariationParams.A:a/10/b/test,AssociateVariationParams.B:a/%2F"; | 44 "AssociateVariationParams.A:a/10/b/test,AssociateVariationParams.B:a/%2F"; |
| 41 ASSERT_TRUE(AssociateParamsFromString(kVariationsString)); | 45 ASSERT_TRUE(AssociateParamsFromString(kVariationsString)); |
| 42 | 46 |
| 43 base::FieldTrialList::CreateFieldTrial(kTrialName, "B"); | 47 base::FieldTrialList::CreateFieldTrial(kTrialName, "B"); |
| 44 EXPECT_EQ("/", variations::GetVariationParamValue(kTrialName, "a")); | 48 EXPECT_EQ("/", variations::GetVariationParamValue(kTrialName, "a")); |
| 45 EXPECT_EQ(std::string(), variations::GetVariationParamValue(kTrialName, "b")); | 49 EXPECT_EQ(std::string(), variations::GetVariationParamValue(kTrialName, "b")); |
| 46 EXPECT_EQ(std::string(), variations::GetVariationParamValue(kTrialName, "x")); | 50 EXPECT_EQ(std::string(), variations::GetVariationParamValue(kTrialName, "x")); |
| 47 | 51 |
| 48 std::map<std::string, std::string> params; | 52 std::map<std::string, std::string> params; |
| 49 EXPECT_TRUE(variations::GetVariationParams(kTrialName, ¶ms)); | 53 EXPECT_TRUE(variations::GetVariationParams(kTrialName, ¶ms)); |
| 50 EXPECT_EQ(1U, params.size()); | 54 EXPECT_EQ(1U, params.size()); |
| 51 EXPECT_EQ("/", params["a"]); | 55 EXPECT_EQ("/", params["a"]); |
| 52 } | 56 } |
| 53 | 57 |
| 54 TEST_F(VariationsUtilTest, AssociateParamsFromStringWithSameTrial) { | 58 TEST_F(FieldTrialUtilTest, AssociateParamsFromStringWithSameTrial) { |
| 55 const std::string kTrialName = "AssociateVariationParams"; | 59 const std::string kTrialName = "AssociateVariationParams"; |
| 56 const std::string kVariationsString = | 60 const std::string kVariationsString = |
| 57 "AssociateVariationParams.A:a/10/b/test,AssociateVariationParams.A:a/x"; | 61 "AssociateVariationParams.A:a/10/b/test,AssociateVariationParams.A:a/x"; |
| 58 ASSERT_FALSE(AssociateParamsFromString(kVariationsString)); | 62 ASSERT_FALSE(AssociateParamsFromString(kVariationsString)); |
| 59 } | 63 } |
| 60 | 64 |
| 61 TEST_F(VariationsUtilTest, AssociateParamsFromFieldTrialConfig) { | 65 TEST_F(FieldTrialUtilTest, AssociateParamsFromFieldTrialConfig) { |
| 62 const FieldTrialTestingExperimentParams array_kFieldTrialConfig_params_0[] = | 66 const FieldTrialTestingExperimentParams array_kFieldTrialConfig_params_0[] = |
| 63 {{"x", "1"}, {"y", "2"}}; | 67 {{"x", "1"}, {"y", "2"}}; |
| 64 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_0[] = { | 68 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_0[] = { |
| 65 {"TestGroup1", array_kFieldTrialConfig_params_0, 2, nullptr, 0, | 69 {"TestGroup1", array_kFieldTrialConfig_params_0, 2, nullptr, 0, |
| 66 nullptr, 0, nullptr}, | 70 nullptr, 0, nullptr}, |
| 67 }; | 71 }; |
| 68 const FieldTrialTestingExperimentParams array_kFieldTrialConfig_params_1[] = | 72 const FieldTrialTestingExperimentParams array_kFieldTrialConfig_params_1[] = |
| 69 {{"x", "3"}, {"y", "4"}}; | 73 {{"x", "3"}, {"y", "4"}}; |
| 70 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_1[] = { | 74 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_1[] = { |
| 71 {"TestGroup2", array_kFieldTrialConfig_params_0, 2, nullptr, 0, | 75 {"TestGroup2", array_kFieldTrialConfig_params_0, 2, nullptr, 0, |
| (...skipping 18 matching lines...) Expand all Loading... |
| 90 std::map<std::string, std::string> params; | 94 std::map<std::string, std::string> params; |
| 91 EXPECT_TRUE(variations::GetVariationParams("TestTrial1", ¶ms)); | 95 EXPECT_TRUE(variations::GetVariationParams("TestTrial1", ¶ms)); |
| 92 EXPECT_EQ(2U, params.size()); | 96 EXPECT_EQ(2U, params.size()); |
| 93 EXPECT_EQ("1", params["x"]); | 97 EXPECT_EQ("1", params["x"]); |
| 94 EXPECT_EQ("2", params["y"]); | 98 EXPECT_EQ("2", params["y"]); |
| 95 | 99 |
| 96 EXPECT_EQ("TestGroup1", base::FieldTrialList::FindFullName("TestTrial1")); | 100 EXPECT_EQ("TestGroup1", base::FieldTrialList::FindFullName("TestTrial1")); |
| 97 EXPECT_EQ("TestGroup2", base::FieldTrialList::FindFullName("TestTrial2")); | 101 EXPECT_EQ("TestGroup2", base::FieldTrialList::FindFullName("TestTrial2")); |
| 98 } | 102 } |
| 99 | 103 |
| 100 TEST_F(VariationsUtilTest, AssociateFeaturesFromFieldTrialConfig) { | 104 TEST_F(FieldTrialUtilTest, AssociateFeaturesFromFieldTrialConfig) { |
| 101 const base::Feature kFeatureA{"A", base::FEATURE_DISABLED_BY_DEFAULT}; | 105 const base::Feature kFeatureA{"A", base::FEATURE_DISABLED_BY_DEFAULT}; |
| 102 const base::Feature kFeatureB{"B", base::FEATURE_ENABLED_BY_DEFAULT}; | 106 const base::Feature kFeatureB{"B", base::FEATURE_ENABLED_BY_DEFAULT}; |
| 103 const base::Feature kFeatureC{"C", base::FEATURE_DISABLED_BY_DEFAULT}; | 107 const base::Feature kFeatureC{"C", base::FEATURE_DISABLED_BY_DEFAULT}; |
| 104 const base::Feature kFeatureD{"D", base::FEATURE_ENABLED_BY_DEFAULT}; | 108 const base::Feature kFeatureD{"D", base::FEATURE_ENABLED_BY_DEFAULT}; |
| 105 | 109 |
| 106 const char* enable_features[] = {"A", "B"}; | 110 const char* enable_features[] = {"A", "B"}; |
| 107 const char* disable_features[] = {"C", "D"}; | 111 const char* disable_features[] = {"C", "D"}; |
| 108 | 112 |
| 109 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_0[] = { | 113 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_0[] = { |
| 110 {"TestGroup1", nullptr, 0, enable_features, 2, nullptr, 0, nullptr}, | 114 {"TestGroup1", nullptr, 0, enable_features, 2, nullptr, 0, nullptr}, |
| (...skipping 23 matching lines...) Expand all Loading... |
| 134 EXPECT_TRUE(base::FeatureList::IsEnabled(kFeatureA)); | 138 EXPECT_TRUE(base::FeatureList::IsEnabled(kFeatureA)); |
| 135 EXPECT_TRUE(base::FeatureList::IsEnabled(kFeatureB)); | 139 EXPECT_TRUE(base::FeatureList::IsEnabled(kFeatureB)); |
| 136 EXPECT_TRUE(base::FieldTrialList::IsTrialActive("TestTrial1")); | 140 EXPECT_TRUE(base::FieldTrialList::IsTrialActive("TestTrial1")); |
| 137 | 141 |
| 138 EXPECT_FALSE(base::FieldTrialList::IsTrialActive("TestTrial2")); | 142 EXPECT_FALSE(base::FieldTrialList::IsTrialActive("TestTrial2")); |
| 139 EXPECT_FALSE(base::FeatureList::IsEnabled(kFeatureC)); | 143 EXPECT_FALSE(base::FeatureList::IsEnabled(kFeatureC)); |
| 140 EXPECT_FALSE(base::FeatureList::IsEnabled(kFeatureD)); | 144 EXPECT_FALSE(base::FeatureList::IsEnabled(kFeatureD)); |
| 141 EXPECT_TRUE(base::FieldTrialList::IsTrialActive("TestTrial2")); | 145 EXPECT_TRUE(base::FieldTrialList::IsTrialActive("TestTrial2")); |
| 142 } | 146 } |
| 143 | 147 |
| 144 TEST_F(VariationsUtilTest, AssociateForcingFlagsFromFieldTrialConfig) { | 148 TEST_F(FieldTrialUtilTest, AssociateForcingFlagsFromFieldTrialConfig) { |
| 145 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_0[] = { | 149 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_0[] = { |
| 146 {"TestGroup1", nullptr, 0, nullptr, 0, nullptr, 0, nullptr} | 150 {"TestGroup1", nullptr, 0, nullptr, 0, nullptr, 0, nullptr} |
| 147 }; | 151 }; |
| 148 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_1[] = { | 152 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_1[] = { |
| 149 {"TestGroup2", nullptr, 0, nullptr, 0, nullptr, 0, nullptr}, | 153 {"TestGroup2", nullptr, 0, nullptr, 0, nullptr, 0, nullptr}, |
| 150 {"ForcedGroup2", nullptr, 0, nullptr, 0, nullptr, 0, "flag-2"}, | 154 {"ForcedGroup2", nullptr, 0, nullptr, 0, nullptr, 0, "flag-2"}, |
| 151 }; | 155 }; |
| 152 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_2[] = { | 156 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_2[] = { |
| 153 {"TestGroup3", nullptr, 0, nullptr, 0, nullptr, 0, nullptr}, | 157 {"TestGroup3", nullptr, 0, nullptr, 0, nullptr, 0, nullptr}, |
| 154 {"ForcedGroup3", nullptr, 0, nullptr, 0, nullptr, 0, "flag-3"}, | 158 {"ForcedGroup3", nullptr, 0, nullptr, 0, nullptr, 0, "flag-3"}, |
| (...skipping 12 matching lines...) Expand all Loading... |
| 167 base::CommandLine::ForCurrentProcess()->AppendSwitch("flag-3"); | 171 base::CommandLine::ForCurrentProcess()->AppendSwitch("flag-3"); |
| 168 | 172 |
| 169 base::FeatureList feature_list; | 173 base::FeatureList feature_list; |
| 170 AssociateParamsFromFieldTrialConfig(kConfig, &feature_list); | 174 AssociateParamsFromFieldTrialConfig(kConfig, &feature_list); |
| 171 | 175 |
| 172 EXPECT_EQ("TestGroup1", base::FieldTrialList::FindFullName("TestTrial1")); | 176 EXPECT_EQ("TestGroup1", base::FieldTrialList::FindFullName("TestTrial1")); |
| 173 EXPECT_EQ("ForcedGroup2", base::FieldTrialList::FindFullName("TestTrial2")); | 177 EXPECT_EQ("ForcedGroup2", base::FieldTrialList::FindFullName("TestTrial2")); |
| 174 EXPECT_EQ("ForcedGroup3", base::FieldTrialList::FindFullName("TestTrial3")); | 178 EXPECT_EQ("ForcedGroup3", base::FieldTrialList::FindFullName("TestTrial3")); |
| 175 } | 179 } |
| 176 | 180 |
| 177 } // namespace chrome_variations | 181 } // namespace variations |
| OLD | NEW |