Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chrome/common/variations/variations_util_unittest.cc

Issue 2465953002: Move Field Trial Utils from chrome/common/variations to components/variations/field_trial_util (Closed)
Patch Set: Moved to components/variations/field_trial_util and chrome switches Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/variations/variations_util.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/variations/variations_util.h"
6
7 #include <memory>
8 #include <utility>
9
10 #include "base/command_line.h"
11 #include "base/feature_list.h"
12 #include "base/macros.h"
13 #include "base/metrics/field_trial.h"
14 #include "chrome/common/variations/fieldtrial_testing_config.h"
15 #include "components/variations/variations_associated_data.h"
16 #include "testing/gtest/include/gtest/gtest.h"
17
18 namespace chrome_variations {
19
20 class VariationsUtilTest : public ::testing::Test {
21 public:
22 VariationsUtilTest() : field_trial_list_(nullptr) {}
23
24 ~VariationsUtilTest() override {
25 // Ensure that the maps are cleared between tests, since they are stored as
26 // process singletons.
27 variations::testing::ClearAllVariationIDs();
28 variations::testing::ClearAllVariationParams();
29 }
30
31 private:
32 base::FieldTrialList field_trial_list_;
33
34 DISALLOW_COPY_AND_ASSIGN(VariationsUtilTest);
35 };
36
37 TEST_F(VariationsUtilTest, AssociateParamsFromString) {
38 const std::string kTrialName = "AssociateVariationParams";
39 const std::string kVariationsString =
40 "AssociateVariationParams.A:a/10/b/test,AssociateVariationParams.B:a/%2F";
41 ASSERT_TRUE(AssociateParamsFromString(kVariationsString));
42
43 base::FieldTrialList::CreateFieldTrial(kTrialName, "B");
44 EXPECT_EQ("/", variations::GetVariationParamValue(kTrialName, "a"));
45 EXPECT_EQ(std::string(), variations::GetVariationParamValue(kTrialName, "b"));
46 EXPECT_EQ(std::string(), variations::GetVariationParamValue(kTrialName, "x"));
47
48 std::map<std::string, std::string> params;
49 EXPECT_TRUE(variations::GetVariationParams(kTrialName, &params));
50 EXPECT_EQ(1U, params.size());
51 EXPECT_EQ("/", params["a"]);
52 }
53
54 TEST_F(VariationsUtilTest, AssociateParamsFromStringWithSameTrial) {
55 const std::string kTrialName = "AssociateVariationParams";
56 const std::string kVariationsString =
57 "AssociateVariationParams.A:a/10/b/test,AssociateVariationParams.A:a/x";
58 ASSERT_FALSE(AssociateParamsFromString(kVariationsString));
59 }
60
61 TEST_F(VariationsUtilTest, AssociateParamsFromFieldTrialConfig) {
62 const FieldTrialTestingExperimentParams array_kFieldTrialConfig_params_0[] =
63 {{"x", "1"}, {"y", "2"}};
64 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_0[] = {
65 {"TestGroup1", array_kFieldTrialConfig_params_0, 2, nullptr, 0,
66 nullptr, 0, nullptr},
67 };
68 const FieldTrialTestingExperimentParams array_kFieldTrialConfig_params_1[] =
69 {{"x", "3"}, {"y", "4"}};
70 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_1[] = {
71 {"TestGroup2", array_kFieldTrialConfig_params_0, 2, nullptr, 0,
72 nullptr, 0, nullptr},
73 {"TestGroup2-2", array_kFieldTrialConfig_params_1, 2, nullptr, 0,
74 nullptr, 0, nullptr},
75 };
76 const FieldTrialTestingStudy array_kFieldTrialConfig_studies[] = {
77 {"TestTrial1", array_kFieldTrialConfig_experiments_0, 1},
78 {"TestTrial2", array_kFieldTrialConfig_experiments_1, 2},
79 };
80 const FieldTrialTestingConfig kConfig = {
81 array_kFieldTrialConfig_studies, 2
82 };
83
84 base::FeatureList feature_list;
85 AssociateParamsFromFieldTrialConfig(kConfig, &feature_list);
86
87 EXPECT_EQ("1", variations::GetVariationParamValue("TestTrial1", "x"));
88 EXPECT_EQ("2", variations::GetVariationParamValue("TestTrial1", "y"));
89
90 std::map<std::string, std::string> params;
91 EXPECT_TRUE(variations::GetVariationParams("TestTrial1", &params));
92 EXPECT_EQ(2U, params.size());
93 EXPECT_EQ("1", params["x"]);
94 EXPECT_EQ("2", params["y"]);
95
96 EXPECT_EQ("TestGroup1", base::FieldTrialList::FindFullName("TestTrial1"));
97 EXPECT_EQ("TestGroup2", base::FieldTrialList::FindFullName("TestTrial2"));
98 }
99
100 TEST_F(VariationsUtilTest, AssociateFeaturesFromFieldTrialConfig) {
101 const base::Feature kFeatureA{"A", base::FEATURE_DISABLED_BY_DEFAULT};
102 const base::Feature kFeatureB{"B", base::FEATURE_ENABLED_BY_DEFAULT};
103 const base::Feature kFeatureC{"C", base::FEATURE_DISABLED_BY_DEFAULT};
104 const base::Feature kFeatureD{"D", base::FEATURE_ENABLED_BY_DEFAULT};
105
106 const char* enable_features[] = {"A", "B"};
107 const char* disable_features[] = {"C", "D"};
108
109 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_0[] = {
110 {"TestGroup1", nullptr, 0, enable_features, 2, nullptr, 0, nullptr},
111 };
112 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_1[] = {
113 {"TestGroup2", nullptr, 0, nullptr, 0, disable_features, 2, nullptr},
114 {"TestGroup2-2", nullptr, 0, nullptr, 0, nullptr, 0, nullptr},
115 };
116
117 const FieldTrialTestingStudy array_kFieldTrialConfig_studies[] = {
118 {"TestTrial1", array_kFieldTrialConfig_experiments_0, 1},
119 {"TestTrial2", array_kFieldTrialConfig_experiments_1, 2},
120 };
121
122 const FieldTrialTestingConfig kConfig = {
123 array_kFieldTrialConfig_studies, 2
124 };
125
126 base::FeatureList::ClearInstanceForTesting();
127 std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
128 AssociateParamsFromFieldTrialConfig(kConfig, feature_list.get());
129 base::FeatureList::SetInstance(std::move(feature_list));
130
131 // Check the resulting feature and field trial states. Trials should not be
132 // active until their associated features are queried.
133 EXPECT_FALSE(base::FieldTrialList::IsTrialActive("TestTrial1"));
134 EXPECT_TRUE(base::FeatureList::IsEnabled(kFeatureA));
135 EXPECT_TRUE(base::FeatureList::IsEnabled(kFeatureB));
136 EXPECT_TRUE(base::FieldTrialList::IsTrialActive("TestTrial1"));
137
138 EXPECT_FALSE(base::FieldTrialList::IsTrialActive("TestTrial2"));
139 EXPECT_FALSE(base::FeatureList::IsEnabled(kFeatureC));
140 EXPECT_FALSE(base::FeatureList::IsEnabled(kFeatureD));
141 EXPECT_TRUE(base::FieldTrialList::IsTrialActive("TestTrial2"));
142 }
143
144 TEST_F(VariationsUtilTest, AssociateForcingFlagsFromFieldTrialConfig) {
145 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_0[] = {
146 {"TestGroup1", nullptr, 0, nullptr, 0, nullptr, 0, nullptr}
147 };
148 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_1[] = {
149 {"TestGroup2", nullptr, 0, nullptr, 0, nullptr, 0, nullptr},
150 {"ForcedGroup2", nullptr, 0, nullptr, 0, nullptr, 0, "flag-2"},
151 };
152 const FieldTrialTestingExperiment array_kFieldTrialConfig_experiments_2[] = {
153 {"TestGroup3", nullptr, 0, nullptr, 0, nullptr, 0, nullptr},
154 {"ForcedGroup3", nullptr, 0, nullptr, 0, nullptr, 0, "flag-3"},
155 {"ForcedGroup3-2", nullptr, 0, nullptr, 0, nullptr, 0, "flag-3-2"},
156 };
157 const FieldTrialTestingStudy array_kFieldTrialConfig_studies[] = {
158 {"TestTrial1", array_kFieldTrialConfig_experiments_0, 1},
159 {"TestTrial2", array_kFieldTrialConfig_experiments_1, 2},
160 {"TestTrial3", array_kFieldTrialConfig_experiments_2, 3},
161 };
162 const FieldTrialTestingConfig kConfig = {
163 array_kFieldTrialConfig_studies, 3
164 };
165
166 base::CommandLine::ForCurrentProcess()->AppendSwitch("flag-2");
167 base::CommandLine::ForCurrentProcess()->AppendSwitch("flag-3");
168
169 base::FeatureList feature_list;
170 AssociateParamsFromFieldTrialConfig(kConfig, &feature_list);
171
172 EXPECT_EQ("TestGroup1", base::FieldTrialList::FindFullName("TestTrial1"));
173 EXPECT_EQ("ForcedGroup2", base::FieldTrialList::FindFullName("TestTrial2"));
174 EXPECT_EQ("ForcedGroup3", base::FieldTrialList::FindFullName("TestTrial3"));
175 }
176
177 } // namespace chrome_variations
OLDNEW
« no previous file with comments | « chrome/common/variations/variations_util.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698