Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2465923004: Revert of Delete dead string IDS_AUTOFILL_WARNING_FORM_DISABLED (Closed)

Created:
4 years, 1 month ago by xidachen
Modified:
4 years, 1 month ago
Reviewers:
Evan Stade, estark
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Delete dead string IDS_AUTOFILL_WARNING_FORM_DISABLED (patchset #1 id:1 of https://codereview.chromium.org/2462973002/ ) Reason for revert: Suspect causing failure here: https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/6991 Will reland if it is not the cause. Original issue's description: > Delete dead string IDS_AUTOFILL_WARNING_FORM_DISABLED > > BUG= > > Committed: https://crrev.com/3eb3b4aff2b6fa5be5c69f4a7759d63e506effbf > Cr-Commit-Position: refs/heads/master@{#428716} TBR=estade@chromium.org,estark@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8f36b5f6542de9f586aae5a4c6d136ed8fead433 Cr-Commit-Position: refs/heads/master@{#428765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/autofill_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xidachen
Created Revert of Delete dead string IDS_AUTOFILL_WARNING_FORM_DISABLED
4 years, 1 month ago (2016-10-31 19:17:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465923004/1
4 years, 1 month ago (2016-10-31 19:17:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 19:19:30 UTC) #5
estark
I don't think this change caused that test failure. It looks very similar to https://crbug.com/660343 ...
4 years, 1 month ago (2016-10-31 19:42:35 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 19:49:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f36b5f6542de9f586aae5a4c6d136ed8fead433
Cr-Commit-Position: refs/heads/master@{#428765}

Powered by Google App Engine
This is Rietveld 408576698