Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2465923003: Test packages with ddc on travis (Closed)

Created:
4 years, 1 month ago by vsm
Modified:
4 years, 1 month ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test packages with ddc on travis Here's a setup to test build of various SDK packages with DDC and strong mode per commit on travis. It's not an ideal setup: - If deps / files change, this will need updating. - It only breaks on error, not warning. - It doesn't actually run any package tests. I haven't gone through all packages either. Might be worth automating something like this. See try-run here: https://travis-ci.org/dart-lang/sdk/builds/172066040 R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/830cf7c3ea89b870140c71a6d36de9f6e3c27d00

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -1 line) Patch
M .travis.yml View 2 chunks +2 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A pkg/dev_compiler/tool/build_pkgs.sh View 1 chunk +92 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (4 generated)
vsm
4 years, 1 month ago (2016-10-31 18:25:29 UTC) #4
Jennifer Messerly
https://codereview.chromium.org/2465923003/diff/1/pkg/dev_compiler/tool/build_pkgs.sh File pkg/dev_compiler/tool/build_pkgs.sh (right): https://codereview.chromium.org/2465923003/diff/1/pkg/dev_compiler/tool/build_pkgs.sh#newcode12 pkg/dev_compiler/tool/build_pkgs.sh:12: # Under pkg should we just enumerate the directory? ...
4 years, 1 month ago (2016-10-31 23:35:51 UTC) #5
Jennifer Messerly
but lgtm for starters :)
4 years, 1 month ago (2016-10-31 23:38:38 UTC) #6
vsm
Committed patchset #1 (id:1) manually as 830cf7c3ea89b870140c71a6d36de9f6e3c27d00 (presubmit successful).
4 years, 1 month ago (2016-11-01 13:01:51 UTC) #8
vsm
4 years, 1 month ago (2016-11-01 18:21:42 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/2465923003/diff/1/pkg/dev_compiler/tool/build...
File pkg/dev_compiler/tool/build_pkgs.sh (right):

https://codereview.chromium.org/2465923003/diff/1/pkg/dev_compiler/tool/build...
pkg/dev_compiler/tool/build_pkgs.sh:12: # Under pkg
On 2016/10/31 23:35:51, Jennifer Messerly wrote:
> should we just enumerate the directory? instead of hard coding

I'm thinking a better way to do this would be to a Dart file that walks over all
packages in pkg/ and third_party/pkg, determines their dependencies (a la
global_compile.dart), and invokes DDC on each package in the right order, with
the right summaries.

Powered by Google App Engine
This is Rietveld 408576698