Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: test/inspector/debugger/script-on-after-compile.js

Issue 2465833002: [debugger] simplify fetching scripts for inspector. (Closed)
Patch Set: add comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | test/inspector/debugger/script-on-after-compile-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/inspector/debugger/script-on-after-compile.js
diff --git a/test/inspector/debugger/script-on-after-compile.js b/test/inspector/debugger/script-on-after-compile.js
index 9281ace12a065642ac2667536f96e5c175556d1c..083aa48065e6ca12f71e1c1ee11579761dfed648 100644
--- a/test/inspector/debugger/script-on-after-compile.js
+++ b/test/inspector/debugger/script-on-after-compile.js
@@ -1,7 +1,6 @@
// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Flags: --expose_gc
print("Checks that inspector correctly process compiled scripts");
@@ -49,9 +48,10 @@ addScripts()
.then(() => Protocol.Debugger.enable())
.then(addScripts)
.then(() => Protocol.Debugger.disable())
-
- .then(() => InspectorTest.log("Run gc and then Debugger.enable().."))
- .then(() => Protocol.Runtime.evaluate({ expression: "for (let i = 1; i < 20; ++i) eval(`foo${i} = undefined`); gc();" }))
+ .then(() => InspectorTest.log("Remove script references and re-enable debugger."))
+ .then(() => Protocol.Runtime.evaluate(
+ { expression: "for (let i = 1; i < 20; ++i) eval(`foo${i} = undefined`);" }))
+ .then(() => Protocol.HeapProfiler.collectGarbage())
.then(() => Protocol.Debugger.enable())
.then(InspectorTest.completeTest);
« no previous file with comments | « src/api.cc ('k') | test/inspector/debugger/script-on-after-compile-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698