Get rid of VisibleSelection::expandUsingGranularity()

Get rid of VisibleSelection::expandUsingGranularity()

This patch gets rid of |VisibleSelection::expandUsingGranularity()| by using
|createVisibleSelection()| as a preparation of making |VisibleSelection|
immutable for improving code health.

This patch also change |VisibleSelection| constructor to call |validate()| with
passed granularity rather than passing character granularity.

BUG=660320
TEST=n/a; no behavior changes

Committed: https://crrev.com/4af4fd436f8224291702adcd453c840bb2af163a
Cr-Commit-Position: refs/heads/master@{#428954}

[yosin_UTC9, 2016-10-31 06:11:21]

Description was changed from

==========
2016-10-31T15:09:59

BUG=
==========

to

==========
2016-10-31T15:09:59

BUG=660320
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-31 06:12:01]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 06:12:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 06:24:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 06:24:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yosin_UTC9, 2016-10-31 07:02:51]

Description was changed from

==========
2016-10-31T15:09:59

BUG=660320
TEST=n/a; no behavior changes
==========

to

==========
Get rid of VisibleSelection::expandUsingGranularity()

This patch gets rid of |VisibleSelection::expandUsingGranularity()| by using
|createVisibleSelection()| as a preparation of making |VisibleSelection|
immutable for improving code health.

This patch also change |VisibleSelection| constructor to call |validate()| with
passed granularity rather than passing character granularity.

BUG=660320
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-31 07:17:29]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 07:17:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 07:41:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 07:41:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yosin_UTC9, 2016-10-31 09:17:16]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 09:17:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-31 10:41:55]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-10-31 10:41:55]

PTAL

Not only "core/editing" but also "Source/web/mac/WebSubstringUtil.mm"

[commit-bot: I haz the power, 2016-10-31 10:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 10:55:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xiaocheng, 2016-11-01 01:59:41]

lgtm

[tkent, 2016-11-01 02:13:27]

lgtm

[yosin_UTC9, 2016-11-01 05:39:32]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-11-01 05:39:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 07:12:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-01 07:16:05]

Description was changed from

==========
Get rid of VisibleSelection::expandUsingGranularity()

This patch gets rid of |VisibleSelection::expandUsingGranularity()| by using
|createVisibleSelection()| as a preparation of making |VisibleSelection|
immutable for improving code health.

This patch also change |VisibleSelection| constructor to call |validate()| with
passed granularity rather than passing character granularity.

BUG=660320
TEST=n/a; no behavior changes
==========

to

==========
Get rid of VisibleSelection::expandUsingGranularity()

This patch gets rid of |VisibleSelection::expandUsingGranularity()| by using
|createVisibleSelection()| as a preparation of making |VisibleSelection|
immutable for improving code health.

This patch also change |VisibleSelection| constructor to call |validate()| with
passed granularity rather than passing character granularity.

BUG=660320
TEST=n/a; no behavior changes

Committed: https://crrev.com/4af4fd436f8224291702adcd453c840bb2af163a
Cr-Commit-Position: refs/heads/master@{#428954}
==========

[commit-bot: I haz the power, 2016-11-01 07:16:06]

Patchset 3 (id:??) landed as
https://crrev.com/4af4fd436f8224291702adcd453c840bb2af163a
Cr-Commit-Position: refs/heads/master@{#428954}