Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2465783002: Fix a typo in Viewport.MetaTagType (Closed)

Created:
4 years, 1 month ago by wychen
Modified:
4 years, 1 month ago
Reviewers:
bokan
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a typo in Viewport.MetaTagType ViewportDescription::MobileOptimizedMeta was wrongly used as ViewportUMAType::MetaMobileOptimized. BUG= Committed: https://crrev.com/beb964ef5b2767f8149f5b3d82f6e92e4ee897d9 Cr-Commit-Position: refs/heads/master@{#428744}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/dom/ViewportDescription.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 9 (3 generated)
wychen
PTAL
4 years, 1 month ago (2016-10-31 07:49:50 UTC) #2
bokan
Ouch, thanks. lgtm
4 years, 1 month ago (2016-10-31 11:54:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465783002/1
4 years, 1 month ago (2016-10-31 15:27:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 16:55:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/beb964ef5b2767f8149f5b3d82f6e92e4ee897d9 Cr-Commit-Position: refs/heads/master@{#428744}
4 years, 1 month ago (2016-10-31 17:16:03 UTC) #8
wychen
4 years, 1 month ago (2016-11-02 21:34:44 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/2465783002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/ViewportDescription.cpp (right):

https://codereview.chromium.org/2465783002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ViewportDescription.cpp:292:
metaTagTypeHistogram.count(MetaMobileOptimized);
MobileOptimizedMeta is 2, while MetaMobileOptimized is 5. ConstantWidth
(Viewport meta with constant width) was overcounted.

Powered by Google App Engine
This is Rietveld 408576698