Fix memory leak in NetworkThrottlingObserverTest

Fix memory leak in NetworkThrottlingObserverTest

DBusThreadManager is initialized but not shut down in
NetworkThrottlingObserverTest. This causes one of the trybots
to fail.
While there, fix a couple of style issues.

BUG=chromium:634529, chromium:642811
Committed: https://crrev.com/441d475906634f882776abee5847f04162226a73
Cr-Commit-Position: refs/heads/master@{#428675}

[kirtika1, 2016-10-31 04:11:54]

Description was changed from

==========
Fix memory leak in NetworkThrottlingObserverTest

DBusThreadManager is initialized but not shut down in
NetworkThrottlingObserverTest. This causes one of the trybots
to fail.
While there, fix a couple of style issues.

BUG=chromium:634529, chromium:642811
==========

to

==========
Fix memory leak in NetworkThrottlingObserverTest

DBusThreadManager is initialized but not shut down in
NetworkThrottlingObserverTest. This causes one of the trybots
to fail.
While there, fix a couple of style issues.

BUG=chromium:634529, chromium:642811
==========

[kirtika1, 2016-10-31 04:11:54]

kirtika@google.com changed reviewers:
+ stevenjb@chromium.org, thestig@chromium.org

[kirtika1, 2016-10-31 04:11:58]

The CQ bit was checked by kirtika@google.com

[commit-bot: I haz the power, 2016-10-31 04:12:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 04:12:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 04:12:11]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[kirtika1, 2016-10-31 04:13:36]

The CQ bit was checked by kirtika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 04:13:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2016-10-31 04:34:57]

rslgtm

[tyoshino (SeeGerritForStatus), 2016-10-31 04:35:02]

On 2016/10/31 04:34:57, tyoshino wrote:
> rslgtm

lgtm

[commit-bot: I haz the power, 2016-10-31 04:42:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 04:42:15]

Dry run: This issue passed the CQ dry run.

[kirtika1, 2016-10-31 04:58:27]

The CQ bit was checked by kirtika@google.com

[commit-bot: I haz the power, 2016-10-31 04:58:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 05:04:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 05:04:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kirtika1, 2016-10-31 05:06:36]

On 2016/10/31 04:35:02, tyoshino wrote:
> On 2016/10/31 04:34:57, tyoshino wrote:
> > rslgtm
> 
> lgtm

The presubmit fails with "missing an LGTM from the file owners". I am not sure
what to do here, since I added these files, so am I the owner?
If so, LGTM for network_throttling_observer.cc and
network_throttling_observer_unittest.cc :P

[kirtika1, 2016-10-31 05:07:00]

The CQ bit was checked by kirtika@google.com

[commit-bot: I haz the power, 2016-10-31 05:07:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 05:17:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 05:17:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kirtika1, 2016-10-31 06:17:09]

The CQ bit was checked by kirtika@google.com

[kirtika1, 2016-10-31 06:17:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org, kirtika@google.com
Link to the patchset: https://codereview.chromium.org/2465743003/#ps20001
(title: "Fix memory leak in NetworkThrottlingObserverTest")

[commit-bot: I haz the power, 2016-10-31 06:17:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kirtika1, 2016-10-31 06:18:59]

On 2016/10/31 05:17:23, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Added TBR= line as suggested by tyoshino@ to work around the OWNERS check.
stevenjb@ - what should be done to add owners for these files? Do we need a new
CL for the OWNERS file?

[tyoshino (SeeGerritForStatus), 2016-10-31 06:20:09]

tyoshino@chromium.org changed reviewers:
+ satorux@chromium.org

[tyoshino (SeeGerritForStatus), 2016-10-31 06:20:42]

On 2016/10/31 06:18:59, kirtika1 wrote:
> On 2016/10/31 05:17:23, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> Added TBR= line as suggested by tyoshino@ to work around the OWNERS check.
> stevenjb@ - what should be done to add owners for these files? Do we need a
new
> CL for the OWNERS file?

I've added satorux@ from the OWNERS of the upper directory.

satorux@, could you please review this?

[commit-bot: I haz the power, 2016-10-31 06:24:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 06:24:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[satorux1, 2016-10-31 06:34:43]

lgtm

https://codereview.chromium.org/2465743003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/net/network_throttling_observer_unittest.cc
(right):

https://codereview.chromium.org/2465743003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/net/network_throttling_observer_unittest.cc:32:
mock_manager_client_ = new NiceMock<MockShillManagerClient>();
maybe add a comment like: // This will be owned by DBusThreadManager

[kirtika1, 2016-10-31 06:36:31]

The CQ bit was checked by kirtika@google.com

[commit-bot: I haz the power, 2016-10-31 06:36:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kirtika1, 2016-10-31 06:38:26]

The CQ bit was unchecked by kirtika@google.com

[phoglund_chromium, 2016-10-31 09:27:36]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2016-10-31 09:27:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2016-10-31 09:53:28]

OK, phoglund.

kirtika, we'll land this. Please address satorux's comment later in a separate
patch.

Thanks

[commit-bot: I haz the power, 2016-10-31 09:54:49]

Description was changed from

==========
Fix memory leak in NetworkThrottlingObserverTest

DBusThreadManager is initialized but not shut down in
NetworkThrottlingObserverTest. This causes one of the trybots
to fail.
While there, fix a couple of style issues.

BUG=chromium:634529, chromium:642811
==========

to

==========
Fix memory leak in NetworkThrottlingObserverTest

DBusThreadManager is initialized but not shut down in
NetworkThrottlingObserverTest. This causes one of the trybots
to fail.
While there, fix a couple of style issues.

BUG=chromium:634529, chromium:642811
==========

[commit-bot: I haz the power, 2016-10-31 09:54:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-31 09:57:09]

Description was changed from

==========
Fix memory leak in NetworkThrottlingObserverTest

DBusThreadManager is initialized but not shut down in
NetworkThrottlingObserverTest. This causes one of the trybots
to fail.
While there, fix a couple of style issues.

BUG=chromium:634529, chromium:642811
==========

to

==========
Fix memory leak in NetworkThrottlingObserverTest

DBusThreadManager is initialized but not shut down in
NetworkThrottlingObserverTest. This causes one of the trybots
to fail.
While there, fix a couple of style issues.

BUG=chromium:634529, chromium:642811

Committed: https://crrev.com/441d475906634f882776abee5847f04162226a73
Cr-Commit-Position: refs/heads/master@{#428675}
==========

[commit-bot: I haz the power, 2016-10-31 09:57:11]

Patchset 2 (id:??) landed as
https://crrev.com/441d475906634f882776abee5847f04162226a73
Cr-Commit-Position: refs/heads/master@{#428675}

[phoglund_chromium, 2016-10-31 12:42:30]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2459353002/ by phoglund@chromium.org.

The reason for reverting is: Fix doesn't appear help. Reverting to be able to
revert base CL.

BUG=660769.