Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 246573003: Move the flush in AppendCommandsToFile outside the loop. (Closed)

Created:
6 years, 8 months ago by rkc
Modified:
6 years, 8 months ago
Reviewers:
marja
CC:
chromium-reviews, marja+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move the flush in AppendCommandsToFile outside the loop. This flush is being called every time we write one single command to the file, causing hundreds of flushes every 2.5s. This is causing jankiness. There is no reason to keep this flush inside the loop, please see the bug for additional details. R=marja@chromium.org BUG=245015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265345

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/sessions/session_backend.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rkc
6 years, 8 months ago (2014-04-22 04:14:58 UTC) #1
rkc
I've removed the TODO since I believe this _is the appropriate place for this flush. ...
6 years, 8 months ago (2014-04-22 04:16:20 UTC) #2
marja
why are you removing the chromeos ifdef?
6 years, 8 months ago (2014-04-22 08:35:41 UTC) #3
rkc
The original code before the removal of the Flush didn't have the #ifdef; but I ...
6 years, 8 months ago (2014-04-22 08:50:52 UTC) #4
marja
lgtm
6 years, 8 months ago (2014-04-22 11:30:42 UTC) #5
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 8 months ago (2014-04-22 17:37:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/246573003/20001
6 years, 8 months ago (2014-04-22 17:37:51 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 18:38:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-22 18:38:47 UTC) #9
rkc
6 years, 8 months ago (2014-04-22 20:25:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r265345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698