Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 246573002: UMA: Add WebCore.WebSocket.SendType (Closed)

Created:
6 years, 8 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

UMA: Add WebCore.WebSocket.SendType Corresponds to Blink change https://codereview.chromium.org/244923002/. Used to study: - how many send() calls are being made - how much binary data sending functionality is used - how many people are using ArrayBufferView version send() BUG=128156, 359926 R=asvitkine@chromium.org, ricea@chromium.org, yhirano@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266143

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed #2 #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 8 months ago (2014-04-22 03:24:58 UTC) #1
Adam Rice
https://codereview.chromium.org/246573002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/246573002/diff/1/tools/metrics/histograms/histograms.xml#newcode29747 tools/metrics/histograms/histograms.xml:29747: + Count the number of send() method call on ...
6 years, 8 months ago (2014-04-22 03:56:52 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/246573002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/246573002/diff/1/tools/metrics/histograms/histograms.xml#newcode29747 tools/metrics/histograms/histograms.xml:29747: + Count the number of send() method call on ...
6 years, 8 months ago (2014-04-22 04:11:42 UTC) #3
Adam Rice
lgtm
6 years, 8 months ago (2014-04-22 04:21:54 UTC) #4
yhirano
6 years, 8 months ago (2014-04-22 08:26:29 UTC) #5
yhirano
lgtm
6 years, 8 months ago (2014-04-22 08:26:37 UTC) #6
tyoshino (SeeGerritForStatus)
+asvitkine for histograms.xml
6 years, 8 months ago (2014-04-23 03:53:51 UTC) #7
Alexei Svitkine (slow)
lgtm
6 years, 8 months ago (2014-04-23 13:19:57 UTC) #8
tyoshino (SeeGerritForStatus)
6 years, 8 months ago (2014-04-25 06:17:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r266143 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698