Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 24657003: GN: Return array from pkgconfig wrapper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/ninja_binary_target_writer.cc
diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index e1344d8d3908470e7d1ec4fe0b3d721b55124271..307fa33c9ac0c425e08d207f742f93877ed9dc46 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -17,19 +17,13 @@ namespace {
// Returns the proper escape options for writing compiler and linker flags.
EscapeOptions GetFlagOptions() {
EscapeOptions opts;
- opts.mode = ESCAPE_NINJA;
-
- // Some flag strings are actually multiple flags that expect to be just
- // added to the command line. We assume that quoting is done by the
- // buildfiles if it wants such things quoted.
- opts.inhibit_quoting = true;
-
+ opts.mode = ESCAPE_NINJA_SHELL;
return opts;
}
struct DefineWriter {
DefineWriter() {
- options.mode = ESCAPE_SHELL;
+ options.mode = ESCAPE_NINJA_SHELL;
}
void operator()(const std::string& s, std::ostream& out) const {
« no previous file with comments | « no previous file | tools/gn/secondary/build/config/linux/BUILD.gn » ('j') | tools/gn/secondary/build/config/linux/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698